Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor librustc_errors::Handler API #64272

Merged
merged 7 commits into from
Sep 23, 2019
Merged

Refactor librustc_errors::Handler API #64272

merged 7 commits into from
Sep 23, 2019

Commits on Sep 17, 2019

  1. Replace DiagnosticBuilder with Diagnostic when emitting error

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    cdd8055 View commit details
    Browse the repository at this point in the history

  2. Take Diagnostic in Handler::emit_diagnostic

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    0b586b4 View commit details
    Browse the repository at this point in the history

  3. Privatize DiagnosticBuilder constructors

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    2a3930d View commit details
    Browse the repository at this point in the history

  4. Remove Handler::cancel

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    998df0d View commit details
    Browse the repository at this point in the history

  5. Remove Handler::{emit, emit_with_code}

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    b304e60 View commit details
    Browse the repository at this point in the history

  6. Remove unused methods from Handler

    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    2a767ee View commit details
    Browse the repository at this point in the history

  7. Protect error handler fields with single lock 

    This avoids concurrency-related bugs when locks are acquired for too
short a time and similar cases.
    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    4cc5aaa View commit details
    Browse the repository at this point in the history