Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for arbitrary self types in E0599 #64056

Merged
merged 2 commits into from
Sep 3, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Sep 1, 2019

Fix #62373

@rust-highfive
Copy link
Collaborator

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2019
src/librustc/ty/context.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/expr.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/expr.rs Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Sep 1, 2019

r? @Centril @bors r+

@bors
Copy link
Contributor

bors commented Sep 1, 2019

📌 Commit 141f5a7 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned zackmdavis Sep 1, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 1, 2019
…ntril

Account for arbitrary self types in E0599

Fix rust-lang#62373
Centril added a commit to Centril/rust that referenced this pull request Sep 3, 2019
…ntril

Account for arbitrary self types in E0599

Fix rust-lang#62373
Centril added a commit to Centril/rust that referenced this pull request Sep 3, 2019
…ntril

Account for arbitrary self types in E0599

Fix rust-lang#62373
Centril added a commit to Centril/rust that referenced this pull request Sep 3, 2019
…ntril

Account for arbitrary self types in E0599

Fix rust-lang#62373
bors added a commit that referenced this pull request Sep 3, 2019
Rollup of 5 pull requests

Successful merges:

 - #64049 (Emit a single error on if expr with expectation and no else clause)
 - #64056 (Account for arbitrary self types in E0599)
 - #64058 (librustc_errors: Extract sugg/subst handling into method)
 - #64071 (use just one name when parameters and fields are the same)
 - #64104 (Emit error on intrinsic to fn ptr casts)

Failed merges:

r? @ghost
@bors bors merged commit 141f5a7 into rust-lang:master Sep 3, 2019
@estebank estebank deleted the arbitrary-self-types branch November 9, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve diagnostics on self types in function signature
5 participants