Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document platform-specific behavior of the iterator returned by std::fs::read_dir #63872

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Document platform-specific behavior of the iterator returned by std::fs::read_dir #63872

merged 1 commit into from
Sep 16, 2019

Conversation

marmistrz
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2019
@hdhoang
Copy link
Contributor

hdhoang commented Sep 6, 2019

ping from triage @Kimundi could you review this?

@JohnCSimon
Copy link
Member

ping from triage again

@Kimundi could you review this?

Thanks!

@jonas-schievink jonas-schievink added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 15, 2019
@jonas-schievink
Copy link
Contributor

r? @jonas-schievink @bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 15, 2019

📌 Commit c8619ae has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 15, 2019
@Centril
Rollup merge of rust-lang#63872 - marmistrz:readdir, r=jonas-schievink
0a2e07e 
Document platform-specific behavior of the iterator returned by std::fs::read_dir
@Centril Centril mentioned this pull request Sep 15, 2019
Merged
bors added a commit that referenced this pull request Sep 15, 2019
@bors
Auto merge of #64491 - Centril:rollup-21wkl69, r=Centril
06c94ee 
Rollup of 3 pull requests

Successful merges:

 - #63872 (Document platform-specific behavior of the iterator returned by std::fs::read_dir)
 - #64250 (save-analysis: Nest typeck tables when processing functions/methods)
 - #64472 (Don't mark expression with attributes as not needing parentheses)

Failed merges:

r? @ghost
@bors bors merged commit c8619ae into rust-lang:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonas-schievink jonas-schievink

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marmistrz @rust-highfive @hdhoang @JohnCSimon @jonas-schievink @bors @Kimundi