Refactor feature_gate.rs into modules & cleanup
#63824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
changed the title
feature_gate.rs into a module & cleanupfeature_gate.rs into modules & cleanup
oli-obk
reviewed
Aug 24, 2019
| }; | ||
| } | ||
|
|
||
| // If you change this, please modify `src/doc/unstable-book` as well. |
There was a problem hiding this comment.
Is this comment relevant? Do we have any file paths to adjust?
There was a problem hiding this comment.
The comment is moved over to active.rs which seemed like the most appropriate place to have it. The latter bits are still relevant but I don't know how much the unstable book still is but that seems like a larger question which is preferably resolved in a more dedicated place. The file paths are still right however.
There was a problem hiding this comment.
Filed as an issue in #63840.
|
@bors r=oli-obk p=5 rollup=never (bitrotty / rebasing this will be painful...) |
|
📌 Commit 3e061f7 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 24, 2019
Refactor `feature_gate.rs` into modules & cleanup Split `src/libsyntax/feature_gate.rs` into `src/libsyntax/feature_gate/` with files: - `accepted.rs` (accepted feature gates) - `removed.rs` (...) - `active.rs` (...) - `builtin_attrs.rs` (definition of builtin attributes and their gates as well as gating `cfg` flags) - `check.rs` (post expansion checking of feature gates) - `mod.rs` (just reexports) Additionally, `tidy.rs` is adjusted to respect the new scheme. Also, `builtin_attrs.rs` sees some cleanup, organization, and DSL-ification to reduce repetition. This is probably best read commit-by-commit I think. r? @oli-obk
|
☀️ Test successful - checks-azure |
This was referenced Aug 24, 2019
Centril
pushed a commit
to Centril/rust
that referenced
this pull request
Aug 24, 2019
Feature gate definitions were split into multiple files in rust-lang#63824 but tidy kept reporting the hard-coded path. Now, it shows the full path to the correct file.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 24, 2019
…=Centril Refactor feature gates After rust-lang#63824, this goes a few steps further by - parsing doc comments in the macros to extract descriptions for feature gates, and - introducing a common `Feature` type to replace the tuples used previously to improve readability. The descriptions are not yet used, but I felt like this PR is a useful enough refactoring on its own. r? @Centril
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 26, 2019
…=Centril Refactor feature gates After rust-lang#63824, this goes a few steps further by - parsing doc comments in the macros to extract descriptions for feature gates, and - introducing a common `Feature` type to replace the tuples used previously to improve readability. The descriptions are not yet used, but I felt like this PR is a useful enough refactoring on its own. r? @Centril
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
src/libsyntax/feature_gate.rsintosrc/libsyntax/feature_gate/with files:accepted.rs(accepted feature gates)removed.rs(...)active.rs(...)builtin_attrs.rs(definition of builtin attributes and their gates as well as gatingcfgflags)check.rs(post expansion checking of feature gates)mod.rs(just reexports)Additionally,
tidy.rsis adjusted to respect the new scheme.Also,
builtin_attrs.rssees some cleanup, organization, and DSL-ification to reduce repetition.This is probably best read commit-by-commit I think.
r? @oli-obk