-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #63744
Rollup of 7 pull requests #63744
Commits on Aug 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d3019d1 - Browse repository at this point
Copy the full SHA d3019d1View commit details
Commits on Aug 6, 2019
-
avoid unnecessary reservations in std::io::Take::read_to_end
Prevously the `read_to_end` implementation for `std::io::Take` used its own `limit` as a cap on the `reservation_size`. However, that could still result in an over-allocation like this: 1. Call `reader.take(5).read_to_end(&mut vec)`. 2. `read_to_end_with_reservation` reserves 5 bytes and calls `read`. 3. `read` writes 5 bytes. 4. `read_to_end_with_reservation` reserves 5 bytes and calls `read`. 5. `read` writes 0 bytes. 6. The read loop ends with `vec` having length 5 and capacity 10. The reservation of 5 bytes was correct for the read at step 2 but unnecessary for the read at step 4. By that second read, `Take::limit` is 0, but the `read_to_end_with_reservation` loop is still using the same `reservation_size` it started with. Solve this by having `read_to_end_with_reservation` take a closure, which lets it get a fresh `reservation_size` for each read. This is an implementation detail which doesn't affect any public API.
Configuration menu - View commit details
-
Copy full SHA for edb5214 - Browse repository at this point
Copy the full SHA edb5214View commit details
Commits on Aug 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ec54340 - Browse repository at this point
Copy the full SHA ec54340View commit details
Commits on Aug 19, 2019
-
Don't use stage naming in RUSTFLAGS environment variables
This patch supports less behavior than before, since specifiying stage 1 vs stage 2 is no longer possible, but that is presumably a somewhat rare use case anyway, so not supporting it seems acceptable (and it can be readded easily if desired).
Configuration menu - View commit details
-
Copy full SHA for 9b3f072 - Browse repository at this point
Copy the full SHA 9b3f072View commit details -
Consolidate sigemptyset workarounds
In sys/unix/process, we work around the sigemptyset linking issues on android in two different ways. This change consolidates these workarounds, and avoids duplicating bindings from `libc`.
Configuration menu - View commit details
-
Copy full SHA for 8e91dca - Browse repository at this point
Copy the full SHA 8e91dcaView commit details
Commits on Aug 20, 2019
-
Restore the rustc_plugin crate in the sysroot
It was accidentally removed in a rebase of rust-lang#62727 Fixes rust-lang#63729
Configuration menu - View commit details
-
Copy full SHA for c561abe - Browse repository at this point
Copy the full SHA c561abeView commit details -
This commit backs out rust-lang#46539 in order to fully leverage rust-lang#63579 where `git` should be able to merge `Cargo.lock` nowadays with only minimal conflicts.
Configuration menu - View commit details
-
Copy full SHA for 815ce8c - Browse repository at this point
Copy the full SHA 815ce8cView commit details -
Rollup merge of rust-lang#63216 - oconnor663:take_read_to_end, r=sfac…
…kler avoid unnecessary reservations in std::io::Take::read_to_end Prevously the `read_to_end` implementation for `std::io::Take` used its own `limit` as a cap on the `reservation_size`. However, that could still result in an over-allocation like this: 1. Call `reader.take(5).read_to_end(&mut vec)`. 2. `read_to_end_with_reservation` reserves 5 bytes and calls `read`. 3. `read` writes 5 bytes. 4. `read_to_end_with_reservation` reserves 5 bytes and calls `read`. 5. `read` writes 0 bytes. 6. The read loop ends with `vec` having length 5 and capacity 10. The reservation of 5 bytes was correct for the read at step 2 but unnecessary for the read at step 4. By that second read, `Take::limit` is 0, but the `read_to_end_with_reservation` loop is still using the same `reservation_size` it started with. Solve this by having `read_to_end_with_reservation` take a closure, which lets it get a fresh `reservation_size` for each read. This is an implementation detail which doesn't affect any public API.
Configuration menu - View commit details
-
Copy full SHA for a5299dd - Browse repository at this point
Copy the full SHA a5299ddView commit details -
Rollup merge of rust-lang#63265 - JohnTitor:implement-nth-back-for-ch…
…unksexactmut, r=scottmcm Implement `nth_back` for ChunksExactMut This is a part of rust-lang#54054. r? @scottmcm
Configuration menu - View commit details
-
Copy full SHA for 60649e3 - Browse repository at this point
Copy the full SHA 60649e3View commit details -
Rollup merge of rust-lang#63691 - timvermeulen:chain-size-hint, r=sco…
…ttmcm Fix bug in iter::Chain::size_hint `Chain::size_hint` currently ignores `self.state`, which means that the size hints of the underlying iterators are always combined regardless of the iteration state. This, of course, should only happen when the state is `ChainState::Both`.
Configuration menu - View commit details
-
Copy full SHA for ff352cd - Browse repository at this point
Copy the full SHA ff352cdView commit details -
Rollup merge of rust-lang#63722 - Mark-Simulacrum:bootstrap-rustflags…
…, r=alexcrichton Don't use stage naming in RUSTFLAGS environment variables This patch supports less behavior than before, since specifiying stage 1 vs stage 2 is no longer possible, but that is presumably a somewhat rare use case anyway, so not supporting it seems acceptable (and it can be readded easily if desired). Fixes rust-lang#33609
Configuration menu - View commit details
-
Copy full SHA for af77aed - Browse repository at this point
Copy the full SHA af77aedView commit details -
Rollup merge of rust-lang#63723 - josephlr:sigemptyset, r=alexcrichton
Consolidate sigemptyset workarounds In sys/unix/process, we work around the sigemptyset linking issues on android in two different ways. This change consolidates these workarounds, and avoids duplicating bindings from `libc`.
Configuration menu - View commit details
-
Copy full SHA for 3662a9f - Browse repository at this point
Copy the full SHA 3662a9fView commit details -
Rollup merge of rust-lang#63736 - SimonSapin:plugin, r=eddyb
Restore the rustc_plugin crate in the sysroot It was accidentally removed in a rebase of rust-lang#62727 Fixes rust-lang#63729 (rls build failure)
Configuration menu - View commit details
-
Copy full SHA for cadf6b9 - Browse repository at this point
Copy the full SHA cadf6b9View commit details -
Rollup merge of rust-lang#63743 - alexcrichton:allow-lock-merge, r=Ma…
…rk-Simulacrum Allow git to merge `Cargo.lock` This commit backs out rust-lang#46539 in order to fully leverage rust-lang#63579 where `git` should be able to merge `Cargo.lock` nowadays with only minimal conflicts.
Configuration menu - View commit details
-
Copy full SHA for 218bcf2 - Browse repository at this point
Copy the full SHA 218bcf2View commit details