Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for maybe_whole_expr in range patterns #63122

Merged
merged 2 commits into from
Aug 1, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jul 30, 2019

Fixes #63115 (fallout from #62550).

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2019
src/libsyntax/parse/token.rs Outdated Show resolved Hide resolved
@petrochenkov
Copy link
Contributor

r=me after looking at #63122 (comment)

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2019
@mati865 mati865 mentioned this pull request Jul 31, 2019
@Centril
Copy link
Contributor Author

Centril commented Jul 31, 2019

@bors r=petrochenkov rollup

@bors
Copy link
Contributor

bors commented Jul 31, 2019

📌 Commit 6551285 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 31, 2019
Account for `maybe_whole_expr` in range patterns

Fixes rust-lang#63115 (fallout from rust-lang#62550).

r? @petrochenkov
Centril added a commit to Centril/rust that referenced this pull request Jul 31, 2019
Account for `maybe_whole_expr` in range patterns

Fixes rust-lang#63115 (fallout from rust-lang#62550).

r? @petrochenkov
Centril added a commit to Centril/rust that referenced this pull request Aug 1, 2019
Account for `maybe_whole_expr` in range patterns

Fixes rust-lang#63115 (fallout from rust-lang#62550).

r? @petrochenkov
@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 1, 2019

This should be p=infinity.

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 1, 2019
Account for `maybe_whole_expr` in range patterns

Fixes rust-lang#63115 (fallout from rust-lang#62550).

r? @petrochenkov
bors added a commit that referenced this pull request Aug 1, 2019
Rollup of 8 pull requests

Successful merges:

 - #62644 (simplify std::io::Write::write rustdoc)
 - #62971 (Add keywords item into the sidebar)
 - #63122 (Account for `maybe_whole_expr` in range patterns)
 - #63158 (Add test for issue-58951)
 - #63170 (cleanup StringReader fields)
 - #63179 (update test cases for vxWorks)
 - #63188 (Fix typos in release notes.)
 - #63191 (ci: fix toolstate not pushing data for Linux)

Failed merges:

r? @ghost
@bors bors merged commit 6551285 into rust-lang:master Aug 1, 2019
@Centril Centril deleted the fix-63115 branch August 1, 2019 18:23
@Centril Centril added the F-slice_patterns `#![feature(slice_patterns)]` label Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-slice_patterns `#![feature(slice_patterns)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"X... range patterns are not supported" occurring in today's nightly
5 participants