Add test self-in-enum-definition
#62916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors rollup |
Centril
commented
Jul 23, 2019
| #[repr(u8)] | ||
| enum Alpha { | ||
| V1 = 41, | ||
| V2 = Self::V1 as u8 + 1, // OK -- but why? |
There was a problem hiding this comment.
oh you're gonna lovehate this
- latest nightly won't compile old versions of winapi #49765
- Allow variant discriminant initializers to refer to other initializer… #50072
- [DO NOT MERGE] see what breaks when we remove this recursive-enum-discriminants hack #61723
It's a peephole hack for excactly Enum::Variant as int
There was a problem hiding this comment.
I thought it felt familiar... 😭.
At some point we should do what @RalfJung suggested in #61723 (comment) since Ralf is right that this is so incredibly niche and imo clearly a bug...
Oh well... not much to do about it here!
There was a problem hiding this comment.
Adjusted the comment to refer to #50072... Should be good to merge now. :)
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
self-in-enum-def
branch
from
b3c7704
to
76929c7
Compare
Centril
force-pushed
the
self-in-enum-def
branch
from
76929c7
to
2e193f7
Compare
|
@bors r+ rollup |
|
📌 Commit 7fdfe8b has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 24, 2019
Add test `self-in-enum-definition` Apparently there was no test covering this... r? @oli-obk cc @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 24, 2019
Rollup of 10 pull requests Successful merges: - rust-lang#62641 (Regenerate character tables for Unicode 12.1) - rust-lang#62716 (state also in the intro that UnsafeCell has no effect on &mut) - rust-lang#62738 (Remove uses of mem::uninitialized from std::sys::cloudabi) - rust-lang#62772 (Suggest trait bound on type parameter when it is unconstrained) - rust-lang#62890 (Normalize use of backticks in compiler messages for libsyntax/*) - rust-lang#62905 (Normalize use of backticks in compiler messages for doc) - rust-lang#62916 (Add test `self-in-enum-definition`) - rust-lang#62917 (Always emit trailing slash error) - rust-lang#62926 (Fix typo in mem::uninitialized doc) - rust-lang#62927 (use PanicMessage in MIR, kill InterpError::description) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Jul 24, 2019
Rollup of 10 pull requests Successful merges: - #62641 (Regenerate character tables for Unicode 12.1) - #62716 (state also in the intro that UnsafeCell has no effect on &mut) - #62738 (Remove uses of mem::uninitialized from std::sys::cloudabi) - #62772 (Suggest trait bound on type parameter when it is unconstrained) - #62890 (Normalize use of backticks in compiler messages for libsyntax/*) - #62905 (Normalize use of backticks in compiler messages for doc) - #62916 (Add test `self-in-enum-definition`) - #62917 (Always emit trailing slash error) - #62926 (Fix typo in mem::uninitialized doc) - #62927 (use PanicMessage in MIR, kill InterpError::description) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently there was no test covering this...
r? @oli-obk
cc @petrochenkov