Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for lldb existences #62671

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Check for lldb existences #62671

merged 1 commit into from
Jul 18, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jul 14, 2019

No description provided.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2019
@alexcrichton
Copy link
Member

Thanks for the PR! This PR name and description however are unfortunately very light on details (e.g. there's no description at all). Can you expand a bit on what this PR is doing, what the change is fixing, and perhaps the motivation as well?

@tesuji
Copy link
Contributor Author

tesuji commented Jul 15, 2019 •
edited
Loading

I'm sorry. I must have been more clear.
The problem is if we do not detect if lldb exists, then when calling rust-lldb,
we could have something like this:

% rust-lldb
/home/lzutao/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rust-lldb: 34: exec: lldb: not found

With this PR, the script will check if lldb exists, and error out if lldb not found.
Also, this PR favors $() subcommand syntax over `command`. Which I think is more
clear to see.

@alexcrichton
Copy link
Member

Ok thanks for the explanation, looks good to me!

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 15, 2019

📌 Commit d649ff3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Jul 17, 2019

@bors rollup

@bors
Copy link
Contributor

bors commented Jul 17, 2019

@lzutao: 🔑 Insufficient privileges: not in try users

@bors
Copy link
Contributor

bors commented Jul 18, 2019

⌛ Testing commit d649ff3 with merge 21d5b8b...

bors added a commit that referenced this pull request Jul 18, 2019
@bors
Auto merge of #62671 - lzutao:tidy-lldb, r=alexcrichton
21d5b8b 
Check for lldb existences
@bors bors mentioned this pull request Jul 18, 2019
Merged
@bors
Copy link
Contributor

bors commented Jul 18, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 21d5b8b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 18, 2019
@bors bors merged commit d649ff3 into rust-lang:master Jul 18, 2019
@tesuji tesuji deleted the tidy-lldb branch July 18, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tesuji @rust-highfive @alexcrichton @bors