Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression test for HRTB bug (issue 30786). #62519

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Regression test for HRTB bug (issue 30786). #62519

merged 1 commit into from
Jul 11, 2019

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Jul 9, 2019

Close #30786.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 9, 2019

📌 Commit a08a5cc has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 9, 2019
@Centril
Rollup merge of rust-lang#62519 - pnkfelix:add-test-for-30786, r=alex…
c1993c8 
…crichton

Regression test for HRTB bug (issue 30786).

Close rust-lang#30786.
@Centril Centril mentioned this pull request Jul 9, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Jul 9, 2019

Failed in #62538 (comment), @bors r-

You need to --bless --compare-mode=nll.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2019
@pnkfelix
Copy link
Member Author

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 10, 2019

📌 Commit fa0809d has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 11, 2019
@Centril
Rollup merge of rust-lang#62519 - pnkfelix:add-test-for-30786, r=pnkf…
03c26f9 
…elix

Regression test for HRTB bug (issue 30786).

Close rust-lang#30786.
@Centril Centril mentioned this pull request Jul 11, 2019
Merged
bors added a commit that referenced this pull request Jul 11, 2019
@bors
Auto merge of #62580 - Centril:rollup-remihe0, r=Centril
6907005 
Rollup of 7 pull requests

Successful merges:

 - #61665 (core: check for pointer equality when comparing Eq slices)
 - #61923 (Prerequisites from dep graph refactoring #2)
 - #62270 (Move async-await tests from run-pass to ui)
 - #62425 (filedesc: don't use ioctl(FIOCLEX) on Linux)
 - #62476 (Continue refactoring macro expansion and resolution)
 - #62519 (Regression test for HRTB bug (issue 30786).)
 - #62557 (Fix typo in libcore/intrinsics.rs)

Failed merges:

r? @ghost
@bors bors merged commit fa0809d into rust-lang:master Jul 11, 2019
@crlf0710 crlf0710 mentioned this pull request Oct 11, 2019
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HRTB bug in streaming iterator
5 participants
@pnkfelix @rust-highfive @alexcrichton @bors @Centril