Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note some safety concerns of raw-ptr-to-ref casts #61785

Merged
merged 1 commit into from
Jun 15, 2019

Conversation

RalfJung
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @rkruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2019
Copy link
Contributor

@hanna-kruppe hanna-kruppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some nits.

src/libcore/ptr/mod.rs Outdated Show resolved Hide resolved
src/libcore/ptr/mod.rs Show resolved Hide resolved
src/libcore/ptr/mod.rs Outdated Show resolved Hide resolved
src/libcore/ptr/mod.rs Show resolved Hide resolved
@RalfJung
Copy link
Member Author

@bors r=rkruppe

@bors
Copy link
Contributor

bors commented Jun 14, 2019

📌 Commit 00bae87 has been approved by rkruppe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2019
@RalfJung
Copy link
Member Author

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Jun 14, 2019
note some safety concerns of raw-ptr-to-ref casts
Centril added a commit to Centril/rust that referenced this pull request Jun 14, 2019
note some safety concerns of raw-ptr-to-ref casts
Centril added a commit to Centril/rust that referenced this pull request Jun 14, 2019
note some safety concerns of raw-ptr-to-ref casts
Centril added a commit to Centril/rust that referenced this pull request Jun 14, 2019
note some safety concerns of raw-ptr-to-ref casts
Centril added a commit to Centril/rust that referenced this pull request Jun 15, 2019
note some safety concerns of raw-ptr-to-ref casts
bors added a commit that referenced this pull request Jun 15, 2019
Rollup of 6 pull requests

Successful merges:

 - #61785 (note some safety concerns of raw-ptr-to-ref casts)
 - #61805 (typeck: Fix ICE for blocks in repeat expr count.)
 - #61813 (Remove some unnecessary symbol interner ops)
 - #61824 (in which we decline to lint single-use lifetimes in `derive`d impls)
 - #61844 (Change `...` to `..=` where applicable)
 - #61854 (Minor cosmetic improvements to accompany PR 61825)

Failed merges:

r? @ghost
@bors bors merged commit 00bae87 into rust-lang:master Jun 15, 2019
@RalfJung RalfJung deleted the as-ref branch June 21, 2019 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants