miri unsizing: fix projecting into a field of an operand #61404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit f23cbea has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 4, 2019
miri unsizing: fix projecting into a field of an operand I don't know why this open-coded an operand field projection. Probably this code predates one or more of my refactorings. Fixes rust-lang/miri#754 r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 4, 2019
miri unsizing: fix projecting into a field of an operand I don't know why this open-coded an operand field projection. Probably this code predates one or more of my refactorings. Fixes rust-lang/miri#754 r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 4, 2019
miri unsizing: fix projecting into a field of an operand I don't know why this open-coded an operand field projection. Probably this code predates one or more of my refactorings. Fixes rust-lang/miri#754 r? @oli-obk
bors
added a commit
that referenced
this pull request
Jun 4, 2019
Rollup of 13 pull requests Successful merges: - #61135 (Fix documentation of `Rc::make_mut` regarding `rc::Weak`.) - #61404 (miri unsizing: fix projecting into a field of an operand) - #61409 (Fix an ICE with a const argument in a trait) - #61413 (Re-implement async fn drop order lowering ) - #61419 (Add an unusual-conversion example to to_uppercase) - #61420 (Succinctify splice docs) - #61444 (Suggest using `as_ref` on `*const T`) - #61446 (On TerminatorKind::DropAndReplace still handle unused_mut correctly) - #61485 (azure: retry s3 upload if it fails) - #61489 (ci: Reenable step timings on AppVeyor) - #61496 (Do not panic in tidy on unbalanced parentheses in cfg's) - #61497 (Treat 0 as special value for codegen-units-std) - #61499 (Add regression test for existential type ICE #53457) Failed merges: r? @ghost
|
Ouch, seems like when a PR is rolled up, the issues it mentions with "Fixes" do not get closed? Cc @Centril |
|
That is strange... cc @kennytm |
|
You'll need to ask GitHub why 😅. But I guess it's because the rollup committer is @Centril who likely does not have write access to rust-lang/miri, so the issue isn't auto-closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why this open-coded an operand field projection. Probably this code predates one or more of my refactorings.
Fixes rust-lang/miri#754
r? @oli-obk