LLD is not supported on Darwin #60003
Conversation
Don't enable LLD when LTO is enabled on Darwin.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
For more context, the LTO and LLD combination is explicitly unsupported in LLVM, but ld64 supports ThinLTO so we should just rely on that. |
|
cc @alexcrichton should we have tests covering this path on OS X? Context: LLD does not support LTO on Darwin. |
|
📌 Commit eb8e426 has been approved by |
bors
added
S-waiting-on-bors
|
Ah yeah this should be fine, IIRC this was just turned on to force usage of LLD on Linux to actually perform ThinLTO. Currently we only perform ThinLTO on our Linux builders, but it's just time budget reasons we haven't enabled it elsewhere. This'll be good to have for when we do it for OSX! While we don't currently have tests we don't have it enabled, so I'm sure we would have run into this had we enabled it on OSX :) |
|
⌛ Testing commit eb8e426 with merge 8ef58a209f41a286f8a5f4762bd0b3fec643072a... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
SGX target: change re-entry abort logic Even though re-entry after exit is generally not acceptable, there is a race condition where the enclave thinks it's exited but userspace doesn't know that yet. An entry during that time will currently result in an enclave panic (see #59997 (comment), #60003 (comment)). Instead of panicking, just do a regular exit on re-entry. cc @jseyfried
LLD is not supported on Darwin Don't enable LLD when LTO is enabled on Darwin.
Rollup of 5 pull requests Successful merges: - #59128 (Emit ansi color codes in the `rendered` field of json diagnostics) - #59646 (const fn: Improve wording) - #59986 (Miri: refactor new allocation tagging) - #60003 (LLD is not supported on Darwin) - #60018 (Miri now supports entropy, but is still slow) Failed merges: r? @ghost
Don't enable LLD when LTO is enabled on Darwin.