Rollup of 5 pull requests #59653

Centril · 2019-04-02T23:40:29Z

Successful merges:

Add 'partition_at_index/_by/_by_key' for slices. #55448 (Add 'partition_at_index/_by/_by_key' for slices.)
improve worst-case performance of BTreeSet intersection v3 #59186 (improve worst-case performance of BTreeSet intersection v3)
Remove adt_def from projections and downcasts in MIR #59514 (Remove adt_def from projections and downcasts in MIR)
wasi: Implement more of the standard library #59619 (wasi: Implement more of the standard library)
Shrink mir::Statement. #59630 (Shrink mir::Statement.)

Failed merges:

… C++'s std::nth_element (a.k.a. quickselect) Add some more notes to the documentation: - Mention that the median can be found if we used `len() / 2`. - Mention that this function is usually called "kth element" in other libraries. Address some comments in PR: - Change wording on some of the documentation - Change recursive function into a loop Update name to `partition_at_index` and add convenience return values. Address reviewer comments: - Don't swap on each iteration when searching for min/max element. - Add some docs about when we panic. - Test that the sum of the lengths of the output matches the length of the input. - Style fix for for-loop. Address more reviewer comments Fix Rng stuff for test Fix doc test build Don't run the partition_at_index test on wasm targets Miri does not support entropy for test partition_at_index

This commit switches the wasi target to loading CLI arguments via the syscalls provided by wasi rather than through the argc/argv passed to the main function. While serving the same purpose it's hoped that using syscalls will make us a bit more portable (less reliance from libstd on an external C library) as well as avoiding the need for a lock!

I've since learned that the mapping between libc fds and wasi fds are expected to be one-to-one, so we can use the raw syscalls for writing to stdout/stderr and reading from stdin! This should help ensure that we don't depend on a C library too unnecessarily.

This routes the `error_string` API to `strerror` in libc which should have more human readable descriptions.

This commit fills out the `std::fs` module and implementation for WASI. Not all APIs are implemented, such as permissions-related ones and `canonicalize`, but all others APIs have been implemented and very lightly tested so far. We'll eventually want to run a more exhaustive test suite! For now the highlights of this commit are: * The `std::fs::File` type is now backed by `WasiFd`, a raw WASI file descriptor. * All APIs in `std::fs` (except permissions/canonicalize) have implementations for the WASI target. * A suite of unstable extension traits were added to `std::os::wasi::fs`. These traits expose the raw filesystem functionality of WASI, namely `*at` syscalls (opening a file relative to an already opened one, for example). Additionally metadata only available on wasi is exposed through these traits. Perhaps one of the most notable parts is the implementation of path-taking APIs. WASI actually has no fundamental API that just takes a path, but rather everything is relative to a previously opened file descriptor. To allow existing APIs to work (that only take a path) WASI has a few syscalls to learn about "pre opened" file descriptors by the runtime. We use these to build a map of existing directory names to file descriptors, and then when using a path we try to anchor it at an already-opened file. This support is very rudimentary though and is intended to be shared with C since it's likely to be so tricky. For now though the C library doesn't expose quite an API for us to use, so we implement it for now and will swap it out as soon as one is available.

The `InlineAsm` variant is extremely rare, and `mir::Statement` often contributes significantly to peak memory usage.

Add 'partition_at_index/_by/_by_key' for slices. This is an analog to C++'s std::nth_element (a.k.a. quickselect). Corresponds to tracking bug rust-lang#55300.

@scottmcm

…ited_again, r=KodrAus improve worst-case performance of BTreeSet intersection v3 Variation of [rust-lang#59078](rust-lang#59078) with `Intersection` remaining a struct r? @scottmcm

@eddyb

…ion-elem, r=eddyb Remove adt_def from projections and downcasts in MIR As part of optimizing generator layouts in MIR, we'd like to allow downcasting generators to variants which do not have a corresponding `def_id`, since they are created by the compiler. This refactor hopes to allow that, without regressing perf. r? @eddyb

wasi: Implement more of the standard library This commit fills out more of the `wasm32-unknown-wasi` target's standard library, notably the `std::fs` module and all of its internals. A few tweaks were made along the way to non-`fs` modules, but the last commit contains the bulk of the work which is to wire up all APIs to their equivalent on WASI targets instead of unconditionally returning "unsupported". After this some basic filesystem operations and such should all be working in WASI!

…=pnkfelix Shrink `mir::Statement`. The `InlineAsm` variant is extremely rare, and `mir::Statement` often contributes significantly to peak memory usage.

Centril · 2019-04-02T23:40:39Z

@bors r+ p=5

bors · 2019-04-02T23:40:41Z

📌 Commit fe4518d has been approved by Centril

bors · 2019-04-03T00:56:24Z

⌛ Testing commit fe4518d with merge 394f45f0b699bfb90801f52d91a64c864c99267b...

bors · 2019-04-03T02:30:08Z

💔 Test failed - checks-travis

rust-highfive · 2019-04-03T02:30:10Z

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:31:50] 
[01:31:51] error: unused import: `ErrorKind`
[01:31:51]  --> src/libstd/sys/redox/fs.rs:5:30
[01:31:51]   |
[01:31:51] 5 | use crate::io::{self, Error, ErrorKind, SeekFrom};
[01:31:51]   |
[01:31:51]   = note: `-D unused-imports` implied by `-D warnings`
[01:31:51] 
[01:31:53] error: aborting due to previous error
---
travis_time:end:081afbe1:start=1554258581042247853,finish=1554258581061669671,duration=19421818
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0b22b871
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0ea379e0
travis_time:start:0ea379e0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2b3db2da
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mokosha and others added 14 commits March 11, 2019 10:31

improve worst-case performance of BTreeSet difference and intersection

f5fee8f

wasi: Implement error_string to get readable errors

32a7684

This routes the `error_string` API to `strerror` in libc which should have more human readable descriptions.

Replace adt_def with name in mir::ProjectionElem::Downcast

ac29ca7

Remove adt_def from PlaceTy and make it a struct

4122d22

Shrink mir::Statement.

d00d639

The `InlineAsm` variant is extremely rare, and `mir::Statement` often contributes significantly to peak memory usage.

Rollup merge of rust-lang#55448 - Mokosha:SortAtIndex, r=bluss

54c602b

Add 'partition_at_index/_by/_by_key' for slices. This is an analog to C++'s std::nth_element (a.k.a. quickselect). Corresponds to tracking bug rust-lang#55300.

Rollup merge of rust-lang#59186 - ssomers:btreeset_intersection_revis…

a08a3a3

…ited_again, r=KodrAus improve worst-case performance of BTreeSet intersection v3 Variation of [rust-lang#59078](rust-lang#59078) with `Intersection` remaining a struct r? @scottmcm

Rollup merge of rust-lang#59630 - nnethercote:shrink-mir-Statement, r…

fe4518d

…=pnkfelix Shrink `mir::Statement`. The `InlineAsm` variant is extremely rare, and `mir::Statement` often contributes significantly to peak memory usage.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 2, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 3, 2019

Centril mentioned this pull request Apr 3, 2019

wasi: Implement more of the standard library #59619

Merged

Centril closed this Apr 3, 2019

Centril deleted the rollup-0kr2w0l branch April 3, 2019 02:33

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #59653

Rollup of 5 pull requests #59653

Centril commented Apr 2, 2019

Centril commented Apr 2, 2019

bors commented Apr 2, 2019

bors commented Apr 3, 2019

bors commented Apr 3, 2019

rust-highfive commented Apr 3, 2019

Rollup of 5 pull requests #59653

Rollup of 5 pull requests #59653

Conversation

Centril commented Apr 2, 2019

Centril commented Apr 2, 2019

bors commented Apr 2, 2019

bors commented Apr 3, 2019

bors commented Apr 3, 2019

rust-highfive commented Apr 3, 2019