[WIP] Internal lints #58701

flip1995 · 2019-02-24T14:29:22Z

I just implemented rust-lang/rust-clippy#3787 and wanted to replace the manual filter*() calls with the new iterators. Then I remembered that I still had this in the pipeline.

I will need some help how to add the -Z internal_lints flag to the bootstrap script. Especially if it is possible to enable the flag for all subcrates but libstd (and maybe some other subcrates).

r? @oli-obk

rust-highfive · 2019-02-24T14:38:45Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:12459198:start=1551018757504139059,finish=1551018758446943958,duration=942804899
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:53] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:53] tidy error: /checkout/src/librustc/lint/internal.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:53] tidy error: /checkout/src/test/ui-fulldeps/internal-lints/ty_tykind_usage.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:53] tidy error: /checkout/src/test/ui-fulldeps/internal-lints/default_hash_types.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:53] tidy error: /checkout/src/test/ui-fulldeps/internal-lints/without_compile_flag.rs:1: copyright notices attributed to the Rust Project Developers are deprecated
[00:03:54] 
[00:03:54] 
[00:03:54] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:54] 
[00:03:54] 
[00:03:54] some tidy checks failed
[00:03:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:54] Build completed unsuccessfully in 0:00:46
[00:03:54] make: *** [tidy] Error 1
[00:03:54] Makefile:68: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:17e7e5f2
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Feb 24 14:36:43 UTC 2019
---
travis_time:end:0523bc70:start=1551019004418831307,finish=1551019004423442387,duration=4611080
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00bf6222
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:032ae90a
travis_time:start:032ae90a
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2d8f44ea
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-02-24T18:38:59Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1a0c345c:start=1551027363873184199,finish=1551027365111917544,duration=1238733345
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:12:51] 
[01:12:51] running 119 tests
[01:13:16] .iiiii...i.....i..i...i..i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i. 100/119
[01:13:21] i......iii.i.....ii
[01:13:21] 
[01:13:21]  finished in 30.085
[01:13:21] travis_fold:end:test_debuginfo

---
travis_time:start:test_run-make
Check compiletest suite=run-make mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:42:31] 
[01:42:31] running 15 tests
[01:42:31] ..ii.iiiiiii...
[01:42:31] 
[01:42:31]  finished in 0.645
[01:42:31] travis_fold:end:test_run-make

---
Check compiletest suite=rustdoc-ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:42:32] 
[01:42:32] running 14 tests
[01:42:37] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:42:37] ...F..........
[01:42:37] 
[01:42:37] ---- [ui] rustdoc-ui/failed-doctest-output.rs stdout ----
[01:42:37] diff of stdout:
[01:42:37] 
[01:42:37] 
[01:42:37] 12 3 | no
[01:42:37] 13   | ^^ not found in this scope
[01:42:37] 14 
[01:42:37] - thread '$DIR/failed-doctest-output.rs - OtherStruct (line 17)' panicked at 'couldn't compile the test', src/librustdoc/test.rs:351:13
[01:42:37] + thread '$DIR/failed-doctest-output.rs - OtherStruct (line 17)' panicked at 'couldn't compile the test', src/librustdoc/test.rs:357:13
[01:42:37] 17 
[01:42:37] 17 
[01:42:37] 18 ---- $DIR/failed-doctest-output.rs - SomeStruct (line 11) stdout ----
[01:42:37] 
[01:42:37] 21 thread 'main' panicked at 'oh no', $DIR/failed-doctest-output.rs:3:1
[01:42:37] 23 
[01:42:37] - ', src/librustdoc/test.rs:372:17
[01:42:37] + ', src/librustdoc/test.rs:378:17
[01:42:37] 25 
[01:42:37] 25 
[01:42:37] 26 
[01:42:37] 27 failures:
[01:42:37] 
[01:42:37] 
[01:42:37] The actual stdout differed from the expected stdout.
[01:42:37] Actual stdout saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/failed-doctest-output/failed-doctest-output.stdout
[01:42:37] To update references, rerun the tests and pass the `--bless` flag
[01:42:37] To only update this specific test, also pass `--test-args failed-doctest-output.rs`
[01:42:37] error: 1 errors occurred comparing output.
[01:42:37] status: exit code: 101
[01:42:37] status: exit code: 101
[01:42:37] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "/checkout/src/test/rustdoc-ui/failed-doctest-output.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/failed-doctest-output/a" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--test" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/failed-doctest-output/auxiliary"
[01:42:37] ------------------------------------------
[01:42:37] 
[01:42:37] running 2 tests
[01:42:37] test /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 17) ... FAILED
[01:42:37] test /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 17) ... FAILED
[01:42:37] test /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 11) ... FAILED
[01:42:37] failures:
[01:42:37] 
[01:42:37] ---- /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 17) stdout ----
[01:42:37] error[E0425]: cannot find value `no` in this scope
---
[01:42:37] 
[01:42:37] thread '/checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 17)' panicked at 'couldn't compile the test', src/librustdoc/test.rs:357:13
[01:42:37] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:42:37] 
[01:42:37] ---- /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 11) stdout ----
[01:42:37] thread '/checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 11)' panicked at 'test executable failed:
[01:42:37] 
[01:42:37] thread 'main' panicked at 'oh no', /checkout/src/test/rustdoc-ui/failed-doctest-output.rs:3:1
[01:42:37] 
[01:42:37] ', src/librustdoc/test.rs:378:17
[01:42:37] 
[01:42:37] 
[01:42:37] 
[01:42:37] failures:
[01:42:37]     /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 17)
[01:42:37]     /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 11)
[01:42:37] test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out
[01:42:37] 
[01:42:37] 
[01:42:37] ------------------------------------------
---
[01:42:37] test result: FAILED. 13 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:42:37] 
[01:42:37] 
[01:42:37] 
[01:42:37] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc-ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:42:37] 
[01:42:37] 
[01:42:37] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:42:37] Build completed unsuccessfully in 0:41:31
[01:42:37] Build completed unsuccessfully in 0:41:31
[01:42:37] Makefile:48: recipe for target 'check' failed
[01:42:37] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:07b13ec6
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Feb 24 18:38:53 UTC 2019
---
travis_time:end:0daf9ddc:start=1551033535443243989,finish=1551033535498220703,duration=54976714
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0b1b5a25
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0e0b0bcd
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2019-02-25T09:28:43Z

You can probably add the flag in

rust/src/bootstrap/builder.rs

Line 849 in c1911ba

if !extra_args.is_empty() {

depending on the value of the mode variable.

src/librustc/lint/internal.rs

rust-highfive · 2019-02-28T18:32:44Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0f06b004:start=1551372389388588519,finish=1551372500824873444,duration=111436284925
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:14:25] 
[01:14:25] running 119 tests
[01:14:50] .iiiii...i.....i..i...i..i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i. 100/119
[01:14:54] i......iii.i.....ii
[01:14:54] 
[01:14:54]  finished in 29.239
[01:14:54] travis_fold:end:test_debuginfo

---
travis_time:start:test_run-make
Check compiletest suite=run-make mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:44:01] 
[01:44:01] running 15 tests
[01:44:01] ..iiiiiii.ii...
[01:44:01] 
[01:44:01]  finished in 0.632
[01:44:01] travis_fold:end:test_run-make

---
Check compiletest suite=rustdoc-ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:44:01] 
[01:44:01] running 16 tests
[01:44:08] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:44:08] ...F............
[01:44:08] 
[01:44:08] ---- [ui] rustdoc-ui/failed-doctest-output.rs stdout ----
[01:44:08] diff of stdout:
[01:44:08] 
[01:44:08] 
[01:44:08] 12 3 | no
[01:44:08] 13   | ^^ not found in this scope
[01:44:08] 14 
[01:44:08] - thread '$DIR/failed-doctest-output.rs - OtherStruct (line 17)' panicked at 'couldn't compile the test', src/librustdoc/test.rs:351:13
[01:44:08] + thread '$DIR/failed-doctest-output.rs - OtherStruct (line 17)' panicked at 'couldn't compile the test', src/librustdoc/test.rs:357:13
[01:44:08] 17 
[01:44:08] 17 
[01:44:08] 18 ---- $DIR/failed-doctest-output.rs - SomeStruct (line 11) stdout ----
[01:44:08] 
[01:44:08] 21 thread 'main' panicked at 'oh no', $DIR/failed-doctest-output.rs:3:1
[01:44:08] 23 
[01:44:08] - ', src/librustdoc/test.rs:372:17
[01:44:08] + ', src/librustdoc/test.rs:378:17
[01:44:08] 25 
[01:44:08] 25 
[01:44:08] 26 
[01:44:08] 27 failures:
[01:44:08] 
[01:44:08] 
[01:44:08] The actual stdout differed from the expected stdout.
[01:44:08] Actual stdout saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/failed-doctest-output/failed-doctest-output.stdout
[01:44:08] To update references, rerun the tests and pass the `--bless` flag
[01:44:08] To only update this specific test, also pass `--test-args failed-doctest-output.rs`
[01:44:08] error: 1 errors occurred comparing output.
[01:44:08] status: exit code: 101
[01:44:08] status: exit code: 101
[01:44:08] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "/checkout/src/test/rustdoc-ui/failed-doctest-output.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/failed-doctest-output/a" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--test" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/failed-doctest-output/auxiliary"
[01:44:08] ------------------------------------------
[01:44:08] 
[01:44:08] running 2 tests
[01:44:08] test /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 17) ... FAILED
[01:44:08] test /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 17) ... FAILED
[01:44:08] test /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 11) ... FAILED
[01:44:08] failures:
[01:44:08] 
[01:44:08] ---- /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 17) stdout ----
[01:44:08] error[E0425]: cannot find value `no` in this scope
---
[01:44:08] 
[01:44:08] thread '/checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 17)' panicked at 'couldn't compile the test', src/librustdoc/test.rs:357:13
[01:44:08] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:44:08] 
[01:44:08] ---- /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 11) stdout ----
[01:44:08] thread '/checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 11)' panicked at 'test executable failed:
[01:44:08] 
[01:44:08] thread 'main' panicked at 'oh no', /checkout/src/test/rustdoc-ui/failed-doctest-output.rs:3:1
[01:44:08] 
[01:44:08] ', src/librustdoc/test.rs:378:17
[01:44:08] 
[01:44:08] 
[01:44:08] 
[01:44:08] failures:
[01:44:08]     /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - OtherStruct (line 17)
[01:44:08]     /checkout/src/test/rustdoc-ui/failed-doctest-output.rs - SomeStruct (line 11)
[01:44:08] test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out
[01:44:08] 
[01:44:08] 
[01:44:08] ------------------------------------------
---
[01:44:08] test result: FAILED. 15 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:44:08] 
[01:44:08] 
[01:44:08] 
[01:44:08] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc-ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:44:08] 
[01:44:08] 
[01:44:08] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:44:08] Build completed unsuccessfully in 0:41:35
[01:44:08] Build completed unsuccessfully in 0:41:35
[01:44:08] Makefile:48: recipe for target 'check' failed
[01:44:08] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2974d37c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu Feb 28 18:32:38 UTC 2019
---
travis_time:end:0f06552c:start=1551378760133140360,finish=1551378760188589678,duration=55449318
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0c587ad0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0eab1de6
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2019-02-28T20:52:20Z

src/librustc/session/config.rs

@@ -1410,6 +1410,9 @@ options! {DebuggingOptions, DebuggingSetter, basic_debugging_options,
    merge_functions: Option<MergeFunctions> = (None, parse_merge_functions, [TRACKED],
        "control the operation of the MergeFunctions LLVM pass, taking
         the same values as the target option of the same name"),
+    internal_lints: bool = (false, parse_bool, [UNTRACKED],


Instead of adding a new flag we could just reuse the -Zunstable-features flag. If the lints are allow by default, we can add deny attributes to crates in steps, and even with cfg_attr to only turn them on after stage0. That will get us around having to touch bootstrap

Yeah I think that is way easier. I'll try that ASAP.

bors · 2019-03-01T00:08:52Z

☔ The latest upstream changes (presumably #58250) made this pull request unmergeable. Please resolve the merge conflicts.

Dylan-DPC-zz · 2019-03-18T18:24:26Z

ping from triage @flip1995 you need to resolve the conflicts

flip1995 · 2019-03-18T19:20:12Z

Oh sorry, I'll get to this tomorrow, but I have to redo this and I will open a new PR

@oli-obk

…li-obk Internal lints take 2 cc rust-lang#58701 cc rust-lang#49509 TODO: Add `#![warn(internal)]` to crates (and fix violations) Crates depending on `rustc_data_structures` - [x] librustc_resolve - [x] librustc_driver - [x] librustc_passes - [x] librustc_metadata - [x] librustc_interface - [x] librustc_save_analysis - [x] librustc_lint - [x] librustc - [x] librustc_incremental - [x] librustc_codegen_utils - [x] libarena - [x] librustc_target - [x] librustc_allocator - [x] librustc_privacy - [x] librustc_traits - [x] librustc_borrowck - [x] libsyntax - [x] librustc_codegen_ssa - [x] libsyntax_ext - [x] librustc_errors - [x] librustc_mir - [x] libsyntax_pos - [x] librustc_typeck Crates with `feature(rustc_private)` Excluding crates, which are already in the list above. Also excluding tools and tests. - [ ] ~~libstd~~ - [x] libfmt_macros - [x] librustdoc r? @oli-obk

@oli-obk

…li-obk Internal lints take 2 cc rust-lang#58701 cc rust-lang#49509 TODO: Add `#![warn(internal)]` to crates (and fix violations) Crates depending on `rustc_data_structures` - [x] librustc_resolve - [x] librustc_driver - [x] librustc_passes - [x] librustc_metadata - [x] librustc_interface - [x] librustc_save_analysis - [x] librustc_lint - [x] librustc - [x] librustc_incremental - [x] librustc_codegen_utils - [x] libarena - [x] librustc_target - [x] librustc_allocator - [x] librustc_privacy - [x] librustc_traits - [x] librustc_borrowck - [x] libsyntax - [x] librustc_codegen_ssa - [x] libsyntax_ext - [x] librustc_errors - [x] librustc_mir - [x] libsyntax_pos - [x] librustc_typeck Crates with `feature(rustc_private)` Excluding crates, which are already in the list above. Also excluding tools and tests. - [ ] ~~libstd~~ - [x] libfmt_macros - [x] librustdoc r? @oli-obk

flip1995 added 5 commits February 24, 2019 14:55

Add -Z flag for internal lints

0a9baa6

Add tests for internal lints

121a5f7

Add internal lints default_hash_types and usage_of_ty_tykind

e7fcbc7

Uplift match_def_path from Clippy

eeb278a

Register internal lints when Z flag is set

bac39a4

rust-highfive assigned oli-obk Feb 24, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2019

Fix rebase fallout

1c0a67c

oli-obk reviewed Feb 25, 2019

View reviewed changes

src/librustc/lint/internal.rs Show resolved Hide resolved

use check_path instead of check_expr

c7b4070

Update stdout of rustdoc test

a06ca43

oli-obk reviewed Feb 28, 2019

View reviewed changes

Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2019

flip1995 closed this Mar 18, 2019

flip1995 mentioned this pull request Mar 20, 2019

Internal lints take 2 #59316

Merged

26 tasks

flip1995 deleted the internal_lints branch March 21, 2019 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Internal lints #58701

[WIP] Internal lints #58701

flip1995 commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

oli-obk commented Feb 25, 2019

rust-highfive commented Feb 28, 2019

oli-obk Feb 28, 2019

flip1995 Mar 3, 2019

bors commented Mar 1, 2019

Dylan-DPC-zz commented Mar 18, 2019

flip1995 commented Mar 18, 2019

[WIP] Internal lints #58701

[WIP] Internal lints #58701

Conversation

flip1995 commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

oli-obk commented Feb 25, 2019

rust-highfive commented Feb 28, 2019

oli-obk Feb 28, 2019

Choose a reason for hiding this comment

flip1995 Mar 3, 2019

Choose a reason for hiding this comment

bors commented Mar 1, 2019

Dylan-DPC-zz commented Mar 18, 2019

flip1995 commented Mar 18, 2019