Check the Self-type of inherent associated constants #58353

matthewjasper · 2019-02-10T15:45:46Z

src/librustc_mir/hair/pattern/mod.rs

matthewjasper · 2019-02-11T21:11:50Z

Removed the overlap with #58371

arielb1 · 2019-02-12T22:22:38Z

src/librustc_typeck/check/mod.rs

@@ -2236,7 +2236,9 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
            hir_id, def_id, substs, user_self_ty, self.tag(),
        );

-        if !substs.is_noop() {
+        if !substs.is_noop() || user_self_ty.map_or(false, |ty| {
+            ty.has_free_regions() || ty.has_projections() || ty.has_infer_types()


~~Is there some justification for why these checks are enough?~~Found it

If there is, could you write it in a comment?

Even if these checks are enough, shouldn't they be run on the pair (substs, ty)? i.e.

let types = (substs, ty); // yes there are TypeFoldable impls for pairs and options if types.has_free_regions() || types.has_projections() || types.has_infer_types() { // ... }

Nah I've seen a comment at https://github.com/rust-lang/rust/blob/a7ae7a21624952f5bfc6aaf88e53351385b89dd4/src/librustc_typeck/check/mod.rs#L2436-L2444

Maybe move the check there it to a separate function (needs_user_type_annotation), while still doing the types trick (where T: TypeFoldable<'tcx> on that function, and then call it)?

arielb1 · 2019-02-12T22:30:29Z

r=me with the needs_user_type_annotation function

arielb1 · 2019-02-14T18:30:44Z

@bors r+

bors · 2019-02-14T18:30:45Z

📌 Commit 283ffcf has been approved by arielb1

@arielb1

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

bors · 2019-02-15T20:04:19Z

⌛ Testing commit 283ffcf with merge df4ed96c920c6fe2ae1b95fac48321e46808be0b...

pietroalbini · 2019-02-15T20:07:57Z

@bors treeclosed=1000

bors · 2019-02-15T20:08:15Z

💔 Test failed - checks-travis

rust-highfive · 2019-02-15T20:08:16Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

pietroalbini · 2019-02-15T20:22:34Z

@bors retry -- apparently we can't clone the repo anymore on macOS

@arielb1

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

@arielb1

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

@arielb1

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

@arielb1

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

@arielb1

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

@arielb1

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

@ghost

Rollup of 16 pull requests Successful merges: - #58100 (Transition librustdoc to Rust 2018) - #58122 (RangeInclusive internal iteration performance improvement.) - #58199 (Add better error message for partial move) - #58227 (Updated RELEASES.md for 1.33.0) - #58353 (Check the Self-type of inherent associated constants) - #58453 (SGX target: fix panic = abort) - #58476 (Remove `LazyTokenStream`.) - #58526 (Special suggestion for illegal unicode curly quote pairs) - #58595 (Turn duration consts into associated consts) - #58609 (Allow Self::Module to be mutated.) - #58628 (Optimise vec![false; N] to zero-alloc) - #58643 (Don't generate minification variables if minification disabled) - #58648 (Update tests to account for cross-platform testing and miri.) - #58654 (Do not underflow after resetting unmatched braces count) - #58658 (Add expected/provided byte alignments to validation error message) - #58667 (Reduce Miri-related Code Repetition `like (n << amt) >> amt`) Failed merges: r? @ghost

rust-highfive assigned arielb1 Feb 10, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2019

arielb1 reviewed Feb 10, 2019

View reviewed changes

src/librustc_mir/hair/pattern/mod.rs Outdated Show resolved Hide resolved

matthewjasper force-pushed the typeck-pattern-constants branch 2 times, most recently from c468033 to a7ae7a2 Compare February 11, 2019 21:10

matthewjasper changed the title ~~Handle user type annotations on range patterns~~ Check the Self-type of inherent associated constants Feb 11, 2019

arielb1 reviewed Feb 12, 2019

View reviewed changes

Check the self-type of inherent associated constants

283ffcf

matthewjasper force-pushed the typeck-pattern-constants branch from a7ae7a2 to 283ffcf Compare February 13, 2019 21:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2019

Centril added a commit to Centril/rust that referenced this pull request Feb 14, 2019

Rollup merge of rust-lang#58353 - matthewjasper:typeck-pattern-consta…

983899b

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

Centril mentioned this pull request Feb 14, 2019

Rollup of 9 pull requests #58470

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2019

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 15, 2019

Centril added a commit to Centril/rust that referenced this pull request Feb 20, 2019

Rollup merge of rust-lang#58353 - matthewjasper:typeck-pattern-consta…

2c2d3f2

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

Centril mentioned this pull request Feb 20, 2019

Rollup of 12 pull requests #58594

Closed

Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019

Rollup merge of rust-lang#58353 - matthewjasper:typeck-pattern-consta…

decd787

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

Centril mentioned this pull request Feb 23, 2019

Rollup of 16 pull requests #58664

Closed

Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019

Rollup merge of rust-lang#58353 - matthewjasper:typeck-pattern-consta…

bad788a

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

Centril mentioned this pull request Feb 23, 2019

Rollup of 16 pull requests #58665

Closed

Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019

Rollup merge of rust-lang#58353 - matthewjasper:typeck-pattern-consta…

d379744

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

Centril mentioned this pull request Feb 23, 2019

Rollup of 15 pull requests #58666

Closed

Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019

Rollup merge of rust-lang#58353 - matthewjasper:typeck-pattern-consta…

e855b05

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

Centril mentioned this pull request Feb 23, 2019

Rollup of 16 pull requests #58668

Closed

Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019

Rollup merge of rust-lang#58353 - matthewjasper:typeck-pattern-consta…

3688643

…nts, r=arielb1 Check the Self-type of inherent associated constants r? @arielb1

Centril mentioned this pull request Feb 23, 2019

Rollup of 16 pull requests #58669

Merged

bors merged commit 283ffcf into rust-lang:master Feb 23, 2019

matthewjasper deleted the typeck-pattern-constants branch February 23, 2019 18:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check the Self-type of inherent associated constants #58353

Check the Self-type of inherent associated constants #58353

matthewjasper commented Feb 10, 2019

matthewjasper commented Feb 11, 2019

arielb1 Feb 12, 2019 •

edited

Loading

arielb1 Feb 12, 2019

arielb1 Feb 12, 2019 •

edited

Loading

arielb1 commented Feb 12, 2019

arielb1 commented Feb 14, 2019

bors commented Feb 14, 2019

bors commented Feb 15, 2019

pietroalbini commented Feb 15, 2019

bors commented Feb 15, 2019

rust-highfive commented Feb 15, 2019

pietroalbini commented Feb 15, 2019

Check the Self-type of inherent associated constants #58353

Check the Self-type of inherent associated constants #58353

Conversation

matthewjasper commented Feb 10, 2019

matthewjasper commented Feb 11, 2019

arielb1 Feb 12, 2019 • edited Loading

Choose a reason for hiding this comment

arielb1 Feb 12, 2019

Choose a reason for hiding this comment

arielb1 Feb 12, 2019 • edited Loading

Choose a reason for hiding this comment

arielb1 commented Feb 12, 2019

arielb1 commented Feb 14, 2019

bors commented Feb 14, 2019

bors commented Feb 15, 2019

pietroalbini commented Feb 15, 2019

bors commented Feb 15, 2019

rust-highfive commented Feb 15, 2019

pietroalbini commented Feb 15, 2019

arielb1 Feb 12, 2019 •

edited

Loading

arielb1 Feb 12, 2019 •

edited

Loading