Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare beta 1.33.0 #57670

Closed
wants to merge 2 commits into from
Closed

Prepare beta 1.33.0 #57670

wants to merge 2 commits into from

Conversation

pietroalbini
Copy link
Member

This PR includes the usual changes for a new beta, and suppresses a few lints on libcore: those lints are false positives caused by an internal attribute (rustc_layout_scalar_valid_range_start) and only happen on stage0.

r? @Mark-Simulacrum

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2019
@pietroalbini pietroalbini changed the base branch from master to beta January 16, 2019 17:23
@pietroalbini
Copy link
Member Author

Woops, forgot to target beta for this PR.

@pietroalbini
Copy link
Member Author

The issue for rustc_layout_scalar_valid_range_start is known: #57183

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jan 16, 2019

📌 Commit b54a00a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2019
@bors
Copy link
Contributor

bors commented Jan 16, 2019

⌛ Testing commit b54a00a with merge b4ccfb66771954c719ddc6e1c273fc5acc52ed00...

@bors
Copy link
Contributor

bors commented Jan 16, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:54:25] test string::test_str_truncate ... ok
[01:54:25] test string::test_str_truncate_invalid_len ... ok
[01:54:25] test string::test_str_truncate_split_codepoint ... ok
[01:54:25] test string::test_split_off_past_end ... ok
[01:54:25] died due to signal 11
[01:54:25] 
[01:54:25] 
[01:54:25] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:54:25] expected success, got: exit code: 3
---
travis_time:end:08abf6aa:start=1547680949936371561,finish=1547680949949857866,duration=13486305
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a8fa265
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:083871a3
travis_time:start:083871a3
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:26340408
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 16, 2019
@Mark-Simulacrum

This comment has been minimized.

Sign in to view
@Mark-Simulacrum

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2019
@pietroalbini
Copy link
Member Author

@bors r=Mark-Simulacrum p=1

@bors
Copy link
Contributor

bors commented Jan 16, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jan 16, 2019

📌 Commit b54a00a has been approved by Mark-Simulacrum

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 16, 2019
@bors
Copy link
Contributor

bors commented Jan 17, 2019

⌛ Testing commit b54a00a with merge 722b4d6...

bors added a commit that referenced this pull request Jan 17, 2019
@bors
Auto merge of #57670 - rust-lang:beta-next, r=Mark-Simulacrum
722b4d6 
Prepare beta 1.33.0

This PR includes the usual changes for a new beta, and suppresses a few lints on libcore: those lints are false positives caused by an internal attribute (`rustc_layout_scalar_valid_range_start`) and only happen on stage0.

r? @Mark-Simulacrum
@bors
Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 722b4d6 to master...

@bors
Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 722b4d6 to master...

@bors
Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 722b4d6 to master...

@bors
Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 722b4d6 to master...

@bors
Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 722b4d6 to master...

@bors
Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 722b4d6 to master...

@bors
Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 722b4d6 to master...

@bors bors mentioned this pull request Jan 17, 2019
Merged
@bors
Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 722b4d6 to master...

@bors
Copy link
Contributor

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 722b4d6 to master...

@pietroalbini
Copy link
Member Author

@bors retry

@pietroalbini pietroalbini reopened this Jan 17, 2019
@pietroalbini
Copy link
Member Author

@bors r=Mark-Simulacrum p=1

@bors
Copy link
Contributor

bors commented Jan 17, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jan 17, 2019

📌 Commit b54a00a has been approved by Mark-Simulacrum

@pietroalbini
Copy link
Member Author

EEEEK this was merged on master, WTF

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jan 17, 2019
@pietroalbini
Revert "Auto merge of rust-lang#57670 - rust-lang:beta-next, r=Mark-S…
d158ef6 
…imulacrum"

This reverts commit 722b4d6, reversing
changes made to 956dba4.
bors added a commit that referenced this pull request Jan 17, 2019
@bors
Auto merge of #57694 - pietroalbini:revert-beta-on-master, r=pietroal…
daa53a5 
…bini

Revert "Auto merge of #57670 - rust-lang:beta-next, r=Mark-Simulacrum"

For whatever reason bors merged this in master `:/`

r? @ghost
@pietroalbini pietroalbini mentioned this pull request Jan 17, 2019
Merged
@pietroalbini
Copy link
Member Author

Let's just create a new one, to be extra sure this isn't going back on master.

@pietroalbini pietroalbini deleted the beta-next branch January 17, 2019 13:55
@pietroalbini pietroalbini restored the beta-next branch January 17, 2019 13:55
VardhanThigle pushed a commit to jethrogb/rust that referenced this pull request Jan 31, 2019
@pietroalbini
Revert "Auto merge of rust-lang#57670 - rust-lang:beta-next, r=Mark-S…
e230972 
…imulacrum"

This reverts commit 722b4d6, reversing
changes made to 956dba4.
@pietroalbini pietroalbini deleted the beta-next branch February 26, 2019 08:28
@pnkfelix pnkfelix mentioned this pull request Mar 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pietroalbini @rust-highfive @Mark-Simulacrum @bors @Centril