librustc: use new [ty, .. len] syntax for fixed vector errors.
#5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Apr 6, 2013
…nger Currently error messages say ``mismatched types: expected `uint` but found `[uint * 10]` (expected uint but found vector)`` rather than `[uint, .. 10]`.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 24, 2022
Moved ``[try_err]`` to restriction Fixes rust-lang#5757 changelog: Moved try_err lint to rescrition for rust-lang#5757
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 8, 2024
Add test for `try_err` lint within try blocks. Fixes rust-lang#5757 Turns out the current `try_err` implementation already skips expressions inside of a try block. When inside of a try block, `Err(_)?` is desugared to a `break` instead of normal `return` . This makes `find_return_type()` function at [this line](https://github.com/rust-lang/rust-clippy/blob/eb4d88e690c431691bc0fd8eaa9f7096ecc2a723/clippy_lints/src/matches/try_err.rs#L29) always returns `None` and skips the check. I just added a test case for try block. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently error messages say
mismatched types: expecteduintbut found[uint * 10](expected uint but found vector)rather than[uint, .. 10].