Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup PartialEq docs. #57357

Merged
merged 8 commits into from
Jan 18, 2019
Merged

Cleanup PartialEq docs. #57357

merged 8 commits into from
Jan 18, 2019

Commits on Jan 5, 2019

  1. Cleanup PartialEq docs. 

    - Cleanup the `impl PartialEq<BookFormat> for Book` implementation
- Implement `impl PartialEq<Book> for BookFormat` so it’s symmetric
  - Fixes rust-lang#53844.
- Removes the last example since it appears to be redundant with the
  previous two examples.
    @frewsxcv
    frewsxcv committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    96678df View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2019

  1. Fix compile error

    @frewsxcv
    frewsxcv committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    0d3dfdf View commit details
    Browse the repository at this point in the history

  2. add missing derive to fix compile error

    @frewsxcv
    frewsxcv committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    319a2c1 View commit details
    Browse the repository at this point in the history

  3. Update cmp.rs

    @frewsxcv
    frewsxcv committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    bbbabdf View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2019

  1. add comment explaining what the derive does

    @frewsxcv
    frewsxcv committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    423a5bb View commit details
    Browse the repository at this point in the history

  2. bring back the example i removed, also add symmetry and simplify impl

    @frewsxcv
    frewsxcv committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    1445a06 View commit details
    Browse the repository at this point in the history

  3. whitespace

    @frewsxcv
    frewsxcv committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    0394dce View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. demonstrate symmetry

    @frewsxcv
    frewsxcv committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    32b2834 View commit details
    Browse the repository at this point in the history