Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make privacy checking, intrinsic checking and liveness checking incremental #57253

Merged
merged 2 commits into from
Jan 19, 2019

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 2, 2019

Blocked on #51487

r? @michaelwoerister

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2019
@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 2, 2019

@bors try

@bors
Copy link
Contributor

bors commented Jan 2, 2019

⌛ Trying commit 31241cedc0d9fc3d3cb8f29cfea9150ec57c3cb1 with merge d9689e3fc0e3cbf86c95524c2672ce17f9fb4cac...

@bors
Copy link
Contributor

bors commented Jan 2, 2019

☀️ Test successful - status-travis
State: approved= try=True

@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 2, 2019

@rust-timer build d9689e3fc0e3cbf86c95524c2672ce17f9fb4cac

@rust-timer
Copy link
Collaborator

Success: Queued d9689e3fc0e3cbf86c95524c2672ce17f9fb4cac with parent 9653034, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit d9689e3fc0e3cbf86c95524c2672ce17f9fb4cac

@bors
Copy link
Contributor

bors commented Jan 13, 2019

☔ The latest upstream changes (presumably #51487) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc changed the title [WIP] Make privacy checking, intrinsic checking and liveness checking incremental Make privacy checking, intrinsic checking and liveness checking incremental Jan 14, 2019
@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 14, 2019

@bors try

@bors
Copy link
Contributor

bors commented Jan 14, 2019

⌛ Trying commit 959c870 with merge 9fcae8a0e896f370b12630f6fa9fef24ead2f08a...

@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 14, 2019

@rust-timer build 9fcae8a0e896f370b12630f6fa9fef24ead2f08a

@rust-timer
Copy link
Collaborator

Success: Queued 9fcae8a0e896f370b12630f6fa9fef24ead2f08a with parent 9aee7ed, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 9fcae8a0e896f370b12630f6fa9fef24ead2f08a

Copy link
Member

@michaelwoerister michaelwoerister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Zoxc! Looks great! I left a couple of minor nits, r=me with those addressed.

Oh my, adding a query needs a lot of boilerplate ...


let krate = tcx.hir().krate();

for &module in tcx.hir().krate().modules.keys() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you re-use the krate binding here that is created the line before. Otherwise it might be confusing, i.e. one might think that's some special reason why tcx.hir().krate() is called twice here.

@@ -782,6 +782,10 @@ impl<'a, 'tcx> Visitor<'tcx> for NamePrivacyVisitor<'a, 'tcx> {
NestedVisitorMap::All(&self.tcx.hir())
}

fn visit_mod(&mut self, _m: &'tcx hir::Mod, _s: Span, _n: ast::NodeId) {
// Don't visit modules inside
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can explain in the comment why we are not recursing down into nested modules? Something like "Don't visit nested modules, since we run a separate visitor walk for each module in privacy_access_levels()".

@@ -917,6 +921,10 @@ impl<'a, 'tcx> Visitor<'tcx> for TypePrivacyVisitor<'a, 'tcx> {
NestedVisitorMap::All(&self.tcx.hir())
}

fn visit_mod(&mut self, _m: &'tcx hir::Mod, _s: Span, _n: ast::NodeId) {
// Don't visit modules inside
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too, just copying the comment is fine.

@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 15, 2019

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented Jan 15, 2019

📌 Commit 959c870 has been approved by michaelwoerister

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 15, 2019
Make privacy checking, intrinsic checking and liveness checking incremental

Blocked on rust-lang#51487

r? @michaelwoerister
bors added a commit that referenced this pull request Jan 15, 2019
Rollup of 7 pull requests

Successful merges:

 - #57253 (Make privacy checking, intrinsic checking and liveness checking incremental)
 - #57352 (forbid manually impl'ing one of an object type's marker traits)
 - #57537 (Small perf improvement for fmt)
 - #57579 (Add core::iter::once_with())
 - #57587 (Add 'rustc-env:RUST_BACKTRACE=0' to const-pat-ice test)
 - #57608 (Simplify 'product' factorial example)
 - #57614 ([rustdoc] Fix crates filtering box not being filled)

Failed merges:

r? @ghost
@Centril
Copy link
Contributor

Centril commented Jan 15, 2019

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented Jan 15, 2019

📌 Commit e301f90 has been approved by michaelwoerister

Centril added a commit to Centril/rust that referenced this pull request Jan 17, 2019
Make privacy checking, intrinsic checking and liveness checking incremental

Blocked on rust-lang#51487

r? @michaelwoerister
Centril added a commit to Centril/rust that referenced this pull request Jan 17, 2019
Make privacy checking, intrinsic checking and liveness checking incremental

Blocked on rust-lang#51487

r? @michaelwoerister
Centril added a commit to Centril/rust that referenced this pull request Jan 17, 2019
Make privacy checking, intrinsic checking and liveness checking incremental

Blocked on rust-lang#51487

r? @michaelwoerister
@bors
Copy link
Contributor

bors commented Jan 19, 2019

⌛ Testing commit e301f90 with merge 1bc6bae...

bors added a commit that referenced this pull request Jan 19, 2019
Make privacy checking, intrinsic checking and liveness checking incremental

Blocked on #51487

r? @michaelwoerister
@bors
Copy link
Contributor

bors commented Jan 19, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: michaelwoerister
Pushing 1bc6bae to master...

@bors bors merged commit e301f90 into rust-lang:master Jan 19, 2019
@Zoxc Zoxc deleted the incr-passes2 branch January 19, 2019 10:29
bors added a commit that referenced this pull request Jan 19, 2019
[WIP] Make some lints incremental

Blocked on #57253

r? @michaelwoerister
bors added a commit that referenced this pull request Jan 31, 2019
Make some lints incremental

Blocked on #57253

r? @michaelwoerister
bors added a commit that referenced this pull request Mar 14, 2019
Make some lints incremental

Blocked on #57253

r? @michaelwoerister
bors added a commit that referenced this pull request Mar 26, 2019
Make some lints incremental

Blocked on #57253

r? @michaelwoerister
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
cuviper added a commit to cuviper/rust that referenced this pull request Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants