Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodules: update clippy from fc24fce7 to 721f688e #57138

Merged
merged 1 commit into from
Dec 29, 2018

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Dec 26, 2018

Fixes clippy toolstate.

Changes:

rustup https://github.com/rust-lang/rust/pull/57069
Rustfmt.
fix breakage from rust-lang/rust#57088
fix a couple of ftrivial typos (NFC).
update CARGO_CLIPPY_HELP string to suggest tool lints.
rustc_tools_util: add readme
rustc_tool_utils: expand Cargo.toml with a few keywords in preparation for crates.io release
Fix macro detection in `empty_loop`.
Changed `macro_backtrace()` to `in_macro()`.
Fix lint detection on macro expansion.

r? @oli-obk

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 26, 2018
@matthiaskrgr matthiaskrgr changed the title submodules: update clippy from fc24fce7 to 19af82c0 [HOLD] submodules: update clippy from fc24fce7 to 19af82c0 Dec 27, 2018
@matthiaskrgr
Copy link
Member Author

as of right now, clippy fails to build, I'll update the PR once that has been fixed upstream

@matthiaskrgr matthiaskrgr changed the title [HOLD] submodules: update clippy from fc24fce7 to 19af82c0 submodules: update clippy from fc24fce7 to 721f688e Dec 27, 2018
@matthiaskrgr
Copy link
Member Author

PR updated, should work again.

@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2018

I think this'll be included in #56924

@Xanewok
Copy link
Member

Xanewok commented Dec 28, 2018

@oli-obk as of now that PR is updating only Cargo, RLS and Miri and since RLS itself fails due to Clippy's broken build, so technically that PR is blocked on this one :(
@ehuss we might want to also bump clippy in the #56924 but that PR was pretty volatile.

However, it was hard to coordinate due to several Miri and RLS test failures - could we possibly r+ and p=1 this instead?

@ehuss
Copy link
Contributor

ehuss commented Dec 28, 2018

I can include it, but I would prefer to p=1 this one since that big PR is risky and has been difficult to move through.

@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2018

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Dec 28, 2018

📌 Commit c7bbf7a15de54a7f242114a4e11f0e0efa765adc has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2018

makes sense. We could also p=1 the bigger PR

Fixes clippy toolstate

Changes:
````
Match on ast/hir::ExprKind::Err
Update *.stderr files
Use -Zui-testing flag
Mention S-inactive-closed PRs in the CONTRIBUTING.md
tests: fix formatting and update test output
base tests: make sure to fail CI if tests need formatting
base tests: switch to nightly toolchain before checking formatting of tests with rustfmt
rustup rust-lang#57069
Rustfmt.
fix breakage from rust-lang#57088
fix a couple of ftrivial typos (NFC).
update CARGO_CLIPPY_HELP string to suggest tool lints.
rustc_tools_util: add readme
rustc_tool_utils: expand Cargo.toml with a few keywords in preparation for crates.io release
Fix macro detection in `empty_loop`.
Changed `macro_backtrace()` to `in_macro()`.
Fix lint detection on macro expansion.
````
@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2018

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Dec 28, 2018

📌 Commit 1654ef8 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Dec 28, 2018

⌛ Testing commit 1654ef8 with merge 8a136d9423aae99919c1296cda00ebd4d22b8d9c...

@bors
Copy link
Contributor

bors commented Dec 28, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 28, 2018
@rust-highfive
Copy link
Collaborator

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:37:23] test string::test_str_clear ... ok
[01:37:23] test string::test_str_truncate ... ok
[01:37:23] test string::test_str_truncate_invalid_len ... ok
[01:37:23] test string::test_str_truncate_split_codepoint ... ok
[01:37:24] died due to signal 11
[01:37:24] 
[01:37:24] 
[01:37:24] 
[01:37:24] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:37:24] 
[01:37:24] 
[01:37:24] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target arm-linux-androideabi
[01:37:24] Build completed unsuccessfully in 1:27:16
---
travis_time:end:0d8ca458:start=1546027294309586929,finish=1546027294328097076,duration=18510147
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:07877fc4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0baf3ae7
travis_time:start:0baf3ae7
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:3af4c8da
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2018

@bors retry random testsuite segfault

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2018
@ehuss
Copy link
Contributor

ehuss commented Dec 28, 2018

#55861 😢

@bors
Copy link
Contributor

bors commented Dec 28, 2018

⌛ Testing commit 1654ef8 with merge d9e3edb...

bors added a commit that referenced this pull request Dec 28, 2018
submodules: update clippy from fc24fce to 721f688

Fixes clippy toolstate.

Changes:
````
rustup #57069
Rustfmt.
fix breakage from #57088
fix a couple of ftrivial typos (NFC).
update CARGO_CLIPPY_HELP string to suggest tool lints.
rustc_tools_util: add readme
rustc_tool_utils: expand Cargo.toml with a few keywords in preparation for crates.io release
Fix macro detection in `empty_loop`.
Changed `macro_backtrace()` to `in_macro()`.
Fix lint detection on macro expansion.
````

r? @oli-obk
@bors
Copy link
Contributor

bors commented Dec 29, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing d9e3edb to master...

@bors bors merged commit 1654ef8 into rust-lang:master Dec 29, 2018
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #57138!

Tested on commit d9e3edb.
Direct link to PR: #57138

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Dec 29, 2018
Tested on commit rust-lang/rust@d9e3edb.
Direct link to PR: <rust-lang/rust#57138>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
@matthiaskrgr matthiaskrgr deleted the clippy branch February 29, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants