Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 17 pull requests #56757

Closed
wants to merge 44 commits into from
Closed

Commits on Nov 28, 2018

  1. Remove not used mod

    `mir_stats` mod has not been used since c1ff104.
    yui-knk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    934e4d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2018

  1. Configuration menu
    Copy the full SHA
    eaeebb5 View commit details
    Browse the repository at this point in the history
  2. Fix line length

    JohnGinger committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    54026c1 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. Fix stderr files

    JohnGinger committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    4cf5702 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    70536d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Configuration menu
    Copy the full SHA
    c0e3f4b View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2018

  1. Configuration menu
    Copy the full SHA
    aa04285 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. Document time of back operations of a Linked List

    Popping and pushing from the end of a linked list is constant time. This
    documentation is already there for popping and pushing from the front.
    
    @bors: r+ 38fe8d2 rollup
    Chris Couzens committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    562f33b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a336228 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ecc4ca5 View commit details
    Browse the repository at this point in the history
  4. Add trailing newline

    aelred committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    3246f49 View commit details
    Browse the repository at this point in the history
  5. reject invalid external doc attributes

    Also, provide a suggestion for the correct syntax.
    euclio committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    c3c2de9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7f7045f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5586c04 View commit details
    Browse the repository at this point in the history
  8. Update the stdsimd submodule

    Includes some new stabilized intrinsics for the wasm32 target!
    
    Closes rust-lang#56292
    alexcrichton committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    07a3d69 View commit details
    Browse the repository at this point in the history
  9. fix install broken link

    mishaker committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    3d23e55 View commit details
    Browse the repository at this point in the history
  10. Add lint for stlib

    aheart committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    f8c03b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Configuration menu
    Copy the full SHA
    30f531b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ee2c06 View commit details
    Browse the repository at this point in the history
  3. Test capacity of ZST vector

    Initially, rust-lang#50233 accidentally changed the capacity of empty ZST. This
    was pointed out during code review. This commit adds a test to prevent
    capacity of ZST vectors from accidentally changing to prevent that
    from happening again.
    KamilaBorowska committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    1006425 View commit details
    Browse the repository at this point in the history
  4. Always set the RDRAND and RDSEED features on SGX

    Jethro Beekman committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    5acab2d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    45b97f2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b17a3f2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8e994a2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b96186b View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Configuration menu
    Copy the full SHA
    517bfe0 View commit details
    Browse the repository at this point in the history
  2. Add test of current behavior (infer free region within closure body) …

    …previously not in test suite.
    pnkfelix committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    29e7ca9 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#56203 - aheart:master, r=varkor

    Add lint for items deprecated in future
    
    Resolves rust-lang#55892
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    e983b55 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#56343 - yui-knk:remove_mir_stats_mod, r=nik…

    …omatsakis
    
    Remove not used mod
    
    `mir_stats` mod has not been used since c1ff104.
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    96b909e View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#56439 - JohnGinger:master, r=nikomatsakis

    Clearer error message for dead assign
    
    I'm not that this is the right place for this (if it needs an RFC or not).
    
    I had the problem where I misunderstood the compiler lint message rust-lang#56436 and other people seem to have had the same problem https://www.reddit.com/r/rust/comments/8cy9p4/value_assigned_to_is_never_read/.
    
    I think this new wording might be slightly clearer (and help out beginners like me). I'm very new though, so there might be some nuance I'm missing that would make this more confusing or a bad idea for other reasons.
    
    I thought I would create a PR to make it easy to change the code if the consensus was that it would make sense to make a change.
    
    If this is the wrong place for this sort of thing I'll happily delete/move it.
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    93c8c5e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#56507 - nikomatsakis:polonius-integrate, r=…

    …MatthewJasper
    
    polonius tweaks
    
    - bump polonius to 0.6.0
    - fix 2-phase-borrow activations
    
    r? @matthewjasper
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    8667b2b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#56572 - kevgrasso:let_self_err_dev, r=estebank

    Contexually dependent error message for E0424 when value is assigned to "self"
    
    This is an improvement for pull request rust-lang#54495 referencing issue rust-lang#54369. If the "self" keyword is assigned a value as though it were a valid identifier, it will now report:
    ```
    let self = "self";
        ^^^^ `self` value is a keyword and may not be bound to variables or shadowed
    ```
    instead of
    ```
    let self = "self";
        ^^^^ `self` value is a keyword only available in methods with `self` parameter
    ```
    If anyone has a better idea for what the error should be I'd be happy to modify it appropriately.
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    289d480 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#56672 - ccouzens:master, r=nikic

    Document time of back operations of a Linked List
    
    Popping and pushing from the end of a linked list is constant time. This
    documentation is already there for popping and pushing from the front.
    
    @bors: r+ 38fe8d2 rollup
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    c33046b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#56677 - aelred:must-use-on-traits, r=estebank

    #[must_use] on traits in stdlib
    
    Based on rust-lang#55506.
    
    Adds `#[must_use]` attribute to traits in the stdlib:
    - `Iterator`
    - `Future`
    - `FnOnce`
    - `Fn`
    - `FnMut`
    
    There may be other traits that should have the attribute, but I couldn't find/think of any.
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    d862bc3 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#56679 - euclio:external-doc-parse, r=estebank

    overhaul external doc attribute diagnostics
    
    This PR improves the error handling and spans for the external doc attribute. Many cases that silently failed before now emit errors, spans are tightened, and the errors have help and suggestions.
    
    I tried to address all the cases that users ran into in the tracking issue.
    
    cc rust-lang#44732
    
    r? @QuietMisdreavus
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    c2655e1 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#56682 - alexcrichton:update-stdsimd, r=niko…

    …matsakis
    
    Update the stdsimd submodule
    
    Includes some new stabilized intrinsics for the wasm32 target!
    
    Closes rust-lang#56292
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    d160d8f View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#56691 - mishaker:fix_doc_install_broken_lin…

    …k, r=jonas-schievink
    
    fix install broken link
    
    solves rust-lang#56690
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    c96c1fb View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#56710 - jethrogb:jb/sgx-target-features, r=…

    …alexcrichton
    
    Always set the RDRAND and RDSEED features on SGX
    
    Not sure if this is 100% correct.
    
    This [Intel article](https://software.intel.com/en-us/articles/intel-software-guard-extensions-tutorial-part-5-enclave-development) goes in great depth regarding using (untrusted) CPUID to see whether RDRAND/RDSEED is supported, and explains what happens to the enclave if the CPUID result is faked.
    
    I'd say that an implementation of SGX that doesn't make RDRAND available to the enclave is so severely limited/broken that it's ok if you get #UD in that case. The case is less clear for RDSEED, but it so far every processor released by Intel with SGX support also has RDSEED (including Gemini Lake).
    
    cc @briansmith
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    a7bfe8a View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#56713 - xfix:vec-test-zst-capacity, r=TimNN

    Test capacity of ZST vector
    
    Initially, rust-lang#50233 accidentally changed the capacity of empty ZST. This was pointed out during code review. This commit adds a test to prevent capacity of ZST vectors from accidentally changing to prevent that from happening again.
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    6911f20 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…

    … r=alexcrichton
    
    Use libbacktrace pretty-printing
    
    r? @alexcrichton
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    9d888a2 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#56725 - piersfinlayson:master, r=alexcrichton

    fix rust-lang/rust issue rust-lang#50583
    
    Rationale for the fix is in rust-lang#50583.  I've verified that before the fix /musl-armhf/lib/libc.a is riddled with the illegal variant of vmov.f64 and after the fix the version built doesn't contain any of these illegal instructions.
    
    I originally thought that the arm-linux-gnueabi version also needed fixing - to add a -mfloat-abi-soft but that's unnecessary as it's compiled with the gnueabi (not hf) compiler (I've some a quick check that the libc.a produced doesn't include VFP instructions).
    
    r? @alexcrichton
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    dbd08c1 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#56731 - GuillaumeGomez:ffi-doc-urls, r=Centril

    Add missing urls in ffi module docs
    
    r? @QuietMisdreavus
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    d9fc1df View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#56738 - turboladen:fix-private_no_mangle_fn…

    …s-message, r=zackmdavis
    
    Fix private_no_mangle_fns message grammar
    
    Simply changes "an warning" to "a warning" in the `private_no_mangle_fns` warning. I started getting this in some code after upgrading to 1.31.0.
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    7f82fe1 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#56746 - pnkfelix:issue-56537-add-test-of-cl…

    …osure-using-region-from-containing-fn, r=nikomatsakis
    
    Add test of current behavior (infer free region within closure body)
    
    This behavior was previously not encoded in our test suite.
    
    it is pretty important that we test this behavior. In particular, in rust-lang#56537  I had proposed expanding the lifetime elision rules so that they would apply to some of the cases encoded in this test, which would cause them to start failing to compile successfully (because the lifetime attached to the return type would start being treated as connected to the lifetime on the input parameter to the lambda expression, which is explicitly *not* what the code wants in this particular case).
    
    In other words, I am trying to ensure that anyone who tries such experiments with lifetime elision in the future quickly finds out why we don't support lifetime elision on lambda expressions (at least not in the naive manner described on rust-lang#56537).
    pietroalbini committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    d6814a3 View commit details
    Browse the repository at this point in the history