Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of the build-manifest tool #56703

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Conversation

alexcrichton
Copy link
Member

Accidentally broken in #56258!

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+

I would also like to include 2c581c5 or something along those lines -- however approving this to hopefully make sure it gets in before the next nightly, since that commit is just to make sure it doesn't break again.

@bors
Copy link
Contributor

bors commented Dec 11, 2018

📌 Commit 98a3867 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2018
@Mark-Simulacrum
Copy link
Member

Ah let's also @bors p=1 this

This builder is not really the correct place to put this, but it
definitely has the time budget and checking this tool builds on just one
platform is more than sufficient.
@alexcrichton
Copy link
Member Author

@bors: r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Dec 11, 2018

📌 Commit ddd8b41 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Dec 11, 2018

⌛ Testing commit ddd8b41 with merge 2cf4ea9817e5be40ce03fcd2165c8f8cf65074da...

@bors
Copy link
Contributor

bors commented Dec 11, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2018
@rust-highfive
Copy link
Collaborator

The job dist-i686-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Building stage2 tool cargo (i686-unknown-freebsd)
[01:02:48]  Downloading crates ...
[01:03:08] warning: spurious network error (2 tries remaining): [6] Couldn't resolve host name (Could not resolve host: crates.io)
[01:03:28] warning: spurious network error (1 tries remaining): [6] Couldn't resolve host name (Could not resolve host: crates.io)
[01:03:48] error: failed to download from `https://crates.io/api/v1/crates/openssl-src/111.1.0+1.1.1a/download`
[01:03:48] Caused by:
[01:03:48]   [6] Couldn't resolve host name (Could not resolve host: crates.io)
[01:03:48] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "i686-unknown-freebsd" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/cargo/Cargo.toml" "--features" "rustc-workspace-hack/all-static" "--message-format" "json"
[01:03:48] expected success, got: exit code: 101
---
travis_time:end:001e2760:start=1544511186036399190,finish=1544511186045466229,duration=9067039
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2da20da4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:024c06d8
travis_time:start:024c06d8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:04365d3e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk
Copy link
Contributor

oli-obk commented Dec 11, 2018

@bors retry network error

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2018
@bors
Copy link
Contributor

bors commented Dec 11, 2018

⌛ Testing commit ddd8b41 with merge 3a31213...

bors added a commit that referenced this pull request Dec 11, 2018
Fix build of the `build-manifest` tool

Accidentally broken in #56258!
@bors
Copy link
Contributor

bors commented Dec 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 3a31213 to master...

@bors bors merged commit ddd8b41 into rust-lang:master Dec 11, 2018
@alexcrichton alexcrichton deleted the fix-tools branch December 17, 2018 02:59
@pietroalbini pietroalbini added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 18, 2018
@pietroalbini pietroalbini added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Dec 18, 2018
bors added a commit that referenced this pull request Dec 18, 2018
[stable] Backport fixes to build-manifest

Backports the following changes to stable:

* #56703: Fix build of the `build-manifest` tool *(partial, just added last commit)*
* #56783: Add `--pinentry-mode=loopback` to deployment script
* #56735: Fix gpg signing in manifest builder

r? @ghost
cc @Mark-Simulacrum @alexcrichton
bors added a commit that referenced this pull request Dec 19, 2018
[beta] Backport fixes to build-manifest

Backports the following changes to beta:

* #56703: Fix build of the `build-manifest` tool *(partial, just added last commit)*
* #56783: Add `--pinentry-mode=loopback` to deployment script
* #56735: Fix gpg signing in manifest builder

r? @ghost
cc @Mark-Simulacrum @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. stable-accepted Accepted for backporting to the compiler in the stable channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants