Fix invalid bitcast taking bool out of a union represented as a scalar #56097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
eddyb
reviewed
Nov 20, 2018
| bx.bitcast(val, ty) | ||
| } | ||
| }; | ||
|
|
||
| // HACK(eddyb) have to bitcast pointers until LLVM removes pointee types. |
There was a problem hiding this comment.
Can you add another comment that mentions that we also need to truncate bool union fields?
Also, the comment should be above the closure.
eddyb
reviewed
Nov 20, 2018
| @@ -243,14 +243,22 @@ impl<'a, 'tcx: 'a, V: CodegenObject> OperandRef<'tcx, V> { | |||
| _ => bug!("OperandRef::extract_field({:?}): not applicable", self) | |||
| }; | |||
|
|
|||
| let bitcast = |bx: &mut Bx, val, ty| { | |||
There was a problem hiding this comment.
The name isn't perfect, maybe rename to to_immediate_or_cast?
|
@bors r+ |
|
📌 Commit 4c21f66 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 23, 2018
Fix invalid bitcast taking bool out of a union represented as a scalar As reported in rust-lang#54668 (comment)
bors
added a commit
that referenced
this pull request
Nov 23, 2018
Rollup of 14 pull requests Successful merges: - #55767 (Disable some pretty-printers when gdb is rust-enabled) - #55838 (Fix #[cfg] for step impl on ranges) - #55869 (Add std::iter::unfold) - #55945 (Ensure that the argument to `static_assert` is a `bool`) - #56022 (When popping in CTFE, perform validation before jumping to next statement to have a better span for the error) - #56048 (Add rustc_codegen_ssa to sysroot) - #56091 (Fix json output in the self-profiler) - #56097 (Fix invalid bitcast taking bool out of a union represented as a scalar) - #56116 (ci: Download clang/lldb from tarballs) - #56120 (Add unstable Literal::subspan().) - #56154 (Pass additional linker flags when targeting Fuchsia) - #56162 (std::str Adapt documentation to reality) - #56163 ([master] Backport 1.30.1 release notes) - #56168 (Fix the tracking issue for hash_raw_entry) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #54668 (comment)