Switch AppVeyor builds to the GCE cloud #55934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Recommended by AppVeyor][1] this isn't done by default for all builds due to the high startup overhead (3-4 minutes for a VM), but that's paltry compared to our overall build times so should be more than applicable! [1]: https://help.appveyor.com/discussions/questions/29832-did-recent-changes-apply-to-possibly-slow-down-builds#comment_46494058
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @kennytm |
|
@bors r+ |
|
📌 Commit 0d990c7 has been approved by |
bors
added
S-waiting-on-bors
|
@bors: p=1 Ideally we'd like to start getting data for this ASAP |
bors
added a commit
that referenced
this pull request
Nov 14, 2018
Switch AppVeyor builds to the GCE cloud [Recommended by AppVeyor][1] this isn't done by default for all builds due to the high startup overhead (3-4 minutes for a VM), but that's paltry compared to our overall build times so should be more than applicable! [1]: https://help.appveyor.com/discussions/questions/29832-did-recent-changes-apply-to-possibly-slow-down-builds#comment_46494058
|
☀️ Test successful - status-appveyor, status-travis |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Nov 14, 2018
Tested on commit rust-lang/rust@6f244c9. Direct link to PR: <rust-lang/rust#55934> 💔 rls on linux: test-pass → test-fail (cc @nrc @Xanewok, @rust-lang/infra).
|
How did this break rls? |
|
@bjorn3 There's a spurious test in RLS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended by AppVeyor this isn't done by default for all builds
due to the high startup overhead (3-4 minutes for a VM), but that's
paltry compared to our overall build times so should be more than
applicable!