Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't inline virtual calls (take 2) #55802

Merged
merged 1 commit into from
Nov 11, 2018
Merged

Don't inline virtual calls (take 2) #55802

merged 1 commit into from
Nov 11, 2018

Commits on Nov 10, 2018

  1. Don't inline virtual calls (take 2) 

    When I fixed the previous mis-optimizations, I didn't realize there were
actually two different places where we mutate `callsites` and both of
them should have the same behavior.

As a result, if a function was inlined and that function contained
virtual function calls, they were incorrectly being inlined. I also
added a test case which covers this.
    @wesleywiser
    wesleywiser committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    3cce5c7 View commit details
    Browse the repository at this point in the history