Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path suggestions in Rust 2018 should point out the change in semantics #55185

Merged
merged 1 commit into from
Oct 28, 2018
Merged

path suggestions in Rust 2018 should point out the change in semantics #55185

merged 1 commit into from
Oct 28, 2018

Conversation

davidtwco
Copy link
Member

Fixes #55130.

This commit extends existing path suggestions to link to documentation
on the changed semantics of use in Rust 2018.

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2018
davidtwco
davidtwco commented Oct 18, 2018
View reviewed changes
src/librustc_resolve/error_reporting.rs Outdated Show resolved Hide resolved
src/librustc_resolve/resolve_imports.rs Outdated Show resolved Hide resolved
@tmandry tmandry mentioned this pull request Oct 18, 2018
Closed
@bors

This comment has been minimized.

Sign in to view
@davidtwco davidtwco force-pushed the issue-55130 branch 3 times, most recently from 2a5dc5e to d2baf92 Compare October 22, 2018 19:59
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2018

📌 Commit d2baf92 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Oct 23, 2018
@pietroalbini
Rollup merge of rust-lang#55185 - davidtwco:issue-55130, r=nikomatsakis
a083070 
path suggestions in Rust 2018 should point out the change in semantics

Fixes rust-lang#55130.

This commit extends existing path suggestions to link to documentation
on the changed semantics of `use` in Rust 2018.

r? @nikomatsakis
@pietroalbini pietroalbini mentioned this pull request Oct 23, 2018
Closed
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2018
@davidtwco
Copy link
Member Author

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Oct 25, 2018

📌 Commit ad0ac6aa1a290c59e4a189a5a0b002ed0d5d3c07 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2018
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2018
@davidtwco
Copy link
Member Author

@bors r=nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2018
@Mark-Simulacrum Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 27, 2018
@Mark-Simulacrum
Copy link
Member

beta-nominating for RC2 inclusion; I think this would be nice to have though not critical

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 27, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#55185 - davidtwco:issue-55130, r=nikomatsakis
be00065 
path suggestions in Rust 2018 should point out the change in semantics

Fixes rust-lang#55130.

This commit extends existing path suggestions to link to documentation
on the changed semantics of `use` in Rust 2018.

r? @nikomatsakis
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Oct 27, 2018
Closed
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2018
@bors

This comment has been minimized.

Sign in to view
@davidtwco
Add note linking to Rust 2018 path semantics docs.
0d06b8c 
This commit extends existing path suggestions to link to documentation
on the changed semantics of `use` in Rust 2018.
@davidtwco
Copy link
Member Author

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Oct 28, 2018

📌 Commit 0d06b8c has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Oct 28, 2018
@kennytm
Rollup merge of rust-lang#55185 - davidtwco:issue-55130, r=nikomatsakis
aaa20c6 
path suggestions in Rust 2018 should point out the change in semantics

Fixes rust-lang#55130.

This commit extends existing path suggestions to link to documentation
on the changed semantics of `use` in Rust 2018.
@kennytm kennytm mentioned this pull request Oct 28, 2018
Merged
bors added a commit that referenced this pull request Oct 28, 2018
@bors
Auto merge of #55433 - kennytm:rollup, r=kennytm
d492c67 
Rollup of 11 pull requests

Successful merges:

 - #55148 (Implement FromStr for PathBuf)
 - #55185 (path suggestions in Rust 2018 should point out the change in semantics)
 - #55191 (Fix sub-variant doc display)
 - #55199 (Impl items have generics)
 - #55244 (Don't rerun MIR passes when inlining)
 - #55252 (Add MaybeUninit::new)
 - #55257 (Allow extern statics with an extern type)
 - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…)
 - #55406 (Update string.rs)
 - #55412 (Fix an ICE in the min_const_fn analysis)
 - #55421 (Add ManuallyDrop::take)
@bors bors merged commit 0d06b8c into rust-lang:master Oct 28, 2018
@davidtwco davidtwco deleted the issue-55130 branch October 28, 2018 19:03
@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 28, 2018
@alexcrichton alexcrichton mentioned this pull request Oct 28, 2018
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 28, 2018
bors added a commit that referenced this pull request Oct 29, 2018
@bors
Auto merge of #55405 - alexcrichton:beta-next, r=pietroalbini
2824a67 
[beta]: Prepare the 1.31.0 beta release

* Update to Cargo's branched 1.31.0 branch
* Update the channel to `beta`

Rolled up beta-accepted PRs:

* #55362: Remove `cargo new --edition` from release notes.
* #55325: Fix link to macros chapter
* #55358: Remove redundant clone (2)
* #55346: Shrink `Statement`.
* #55274: Handle bindings in substructure of patterns with type ascriptions
* #55297: Partial implementation of uniform paths 2.0 to land before beta
* #55192: Fix ordering of nested modules in non-mod.rs mods
* #55185: path suggestions in Rust 2018 should point out the change in semantics
* #55423: back out bogus `Ok`-wrapping suggestion on `?` arm type mismatch

Note that **this does not update the bootstrap compiler** due to #55404
RalfJung
RalfJung reviewed Nov 1, 2018
View reviewed changes
src/librustc_resolve/error_reporting.rs
Some(
"`use` statements changed in Rust 2018; read more at \
<https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-\
clarity.html>".to_string()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting a 404 not found when visiting https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that URL isn't live yet, but will be as of the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik left review comments

@pnkfelix pnkfelix pnkfelix left review comments

@RalfJung RalfJung RalfJung left review comments

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@davidtwco @bors @nikomatsakis @Mark-Simulacrum @steveklabnik @pnkfelix @RalfJung @pietroalbini @rust-highfive