Support specifying edition in doc test #54350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@QuietMisdreavus, @GuillaumeGomez: I've tried to add the banner as well, but I'm not sure how to test it, and I don't know if you want some additional styling on it. Right now it just shows up as a little black (!) icon that says "This code runs with edition 2018/2015". |
This comment has been minimized.
This comment has been minimized.
Munksgaard
force-pushed
the
support-edition-in-doc-test
branch
from
1381281
to
d4f09a2
Compare
This comment has been minimized.
This comment has been minimized.
Munksgaard
force-pushed
the
support-edition-in-doc-test
branch
from
d4f09a2
to
b87338d
Compare
This comment has been minimized.
This comment has been minimized.
Munksgaard
force-pushed
the
support-edition-in-doc-test
branch
from
b87338d
to
bd08d11
Compare
steveklabnik
suggested changes
Sep 19, 2018
|
@steveklabnik is d9e16d6 alright, or would you like more information? |
| @@ -323,6 +323,20 @@ compiles, then the test will fail. However please note that code failing | |||
| with the current Rust release may work in a future release, as new features | |||
| are added. | |||
|
|
|||
| ```text | |||
| /// Only runs on the 2018 edition. | |||
| /// ```edition2018 | |||
There was a problem hiding this comment.
Please add an empty doc comment line before this one.
| /// }; | ||
| /// assert!(result.is_err()); | ||
| /// ``` | ||
|
|
There was a problem hiding this comment.
I'm not sure tests will be called here. Can you add pub fn foo() {} in here please? (or replace fn main with it?)
There was a problem hiding this comment.
I've updated the PR
Munksgaard
force-pushed
the
support-edition-in-doc-test
branch
from
d9e16d6
to
81695df
Compare
Munksgaard
force-pushed
the
support-edition-in-doc-test
branch
from
81695df
to
06b1975
Compare
|
Ok, looks good to me. Waiting for @steveklabnik now. |
steveklabnik
approved these changes
Sep 20, 2018
|
Thank you so much! This is a very important feature. @bors: r+ rollup |
|
📌 Commit 06b1975 has been approved by |
bors
added
S-waiting-on-bors
|
@bors: rollup- (actually this should get tested on its own. habits die hard!) |
Thank you! It's always a pleasure to work with the rust team. |
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Sep 22, 2018
…est, r=steveklabnik Support specifying edition in doc test Fixes rust-lang#52623 r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Sep 22, 2018
Rollup of 16 pull requests Successful merges: - #53652 (define copy_within on slices) - #54261 (Make `dyn` a keyword in the 2018 edition) - #54280 (remove (more) CAS API from Atomic* types where not natively supported) - #54323 (rustbuild: drop color handling) - #54350 (Support specifying edition in doc test) - #54370 (Improve handling of type bounds in `bit_set.rs`.) - #54371 (add -Zui-testing to rustdoc) - #54374 (Make 'proc_macro::MultiSpan' public.) - #54402 (Use no_default_libraries for all NetBSD flavors) - #54409 (Detect `for _ in in bar {}` typo) - #54412 (add applicability to span_suggestion call) - #54413 (Add UI test for deref recursion limit printing twice) - #54415 (parser: Tweak function parameter parsing to avoid rollback on succesfull path) - #54420 (Compress `Liveness` data some more.) - #54422 (Simplify slice's first(_mut) and last(_mut) with get) - #54446 (Unify christianpoveda's emails) Failed merges: - #54058 (Introduce the partition_dedup/by/by_key methods for slices) r? @ghost
bors
added a commit
that referenced
this pull request
Sep 22, 2018
Rollup of 16 pull requests Successful merges: - #53652 (define copy_within on slices) - #54261 (Make `dyn` a keyword in the 2018 edition) - #54280 (remove (more) CAS API from Atomic* types where not natively supported) - #54323 (rustbuild: drop color handling) - #54350 (Support specifying edition in doc test) - #54370 (Improve handling of type bounds in `bit_set.rs`.) - #54371 (add -Zui-testing to rustdoc) - #54374 (Make 'proc_macro::MultiSpan' public.) - #54402 (Use no_default_libraries for all NetBSD flavors) - #54409 (Detect `for _ in in bar {}` typo) - #54412 (add applicability to span_suggestion call) - #54413 (Add UI test for deref recursion limit printing twice) - #54415 (parser: Tweak function parameter parsing to avoid rollback on succesfull path) - #54420 (Compress `Liveness` data some more.) - #54422 (Simplify slice's first(_mut) and last(_mut) with get) - #54446 (Unify christianpoveda's emails) Failed merges: - #54058 (Introduce the partition_dedup/by/by_key methods for slices) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52623
r? @QuietMisdreavus