Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force-inline shallow_resolve at its hottest call site. #53513

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

nnethercote
Copy link
Contributor

It's a ~1% win on keccak and inflate.

It's a ~1% win on `keccak` and `inflate`.
@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2018
@nnethercote
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Aug 20, 2018

⌛ Trying commit b73843f with merge 55fa5150e491e8e5ce6936b862f4878fd3126ffc...

@bors
Copy link
Contributor

bors commented Aug 20, 2018

☀️ Test successful - status-travis
State: approved= try=True

@nnethercote
Copy link
Contributor Author

@rust-timer build 55fa515

@rust-timer
Copy link
Collaborator

Please provide the full 40 character commit hash.

@nnethercote
Copy link
Contributor Author

@rust-timer build 55fa5150e491e8e5ce6936b862f4878fd3126ffc

@rust-timer
Copy link
Collaborator

Success: Queued 55fa5150e491e8e5ce6936b862f4878fd3126ffc with parent f28f648, comparison URL.

@nnethercote
Copy link
Contributor Author

From the comparison URL, these are the ones that I am confident are not noise:

keccak-check
        avg: -1.1%      min: -1.6%      max: 0.1%
inflate-check
        avg: -1.1%      min: -1.5%      max: -0.0%
keccak-debug
        avg: -0.8%      min: -1.4%      max: -0.1%
keccak-opt
        avg: -0.8%      min: -1.3%      max: -0.0%
inflate-debug
        avg: -0.9%      min: -1.2%      max: -0.5%

@nnethercote
Copy link
Contributor Author

It's been a week and this is a tiny change. Let's try a different reviewer: r? @varkor

@rust-highfive rust-highfive assigned varkor and unassigned pnkfelix Aug 26, 2018
@varkor
Copy link
Member

varkor commented Aug 26, 2018

There are some nice gains here, thanks! @bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 26, 2018

📌 Commit b73843f has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2018
@bors
Copy link
Contributor

bors commented Aug 26, 2018

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 26, 2018

📌 Commit b73843f has been approved by varkor

@nnethercote
Copy link
Contributor Author

Thank you for the fast review.

kennytm added a commit to kennytm/rust that referenced this pull request Aug 28, 2018
… r=varkor

Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 28, 2018
… r=varkor

Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 29, 2018
… r=varkor

Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 29, 2018
… r=varkor

Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 30, 2018
… r=varkor

Force-inline `shallow_resolve` at its hottest call site.

It's a ~1% win on `keccak` and `inflate`.
bors added a commit that referenced this pull request Aug 31, 2018
Rollup of 20 pull requests

Successful merges:

 - #51760 (Add another PartialEq example)
 - #53113 (Add example for Cow)
 - #53129 (remove `let x = baz` which was obscuring the real error)
 - #53389 (document effect of join on memory ordering)
 - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.)
 - #53476 (Add partialeq implementation for TryFromIntError type)
 - #53513 (Force-inline `shallow_resolve` at its hottest call site.)
 - #53655 (set applicability)
 - #53702 (Fix stabilisation version for macro_vis_matcher.)
 - #53727 (Do not suggest dereferencing in macro)
 - #53732 (save-analysis: Differentiate foreign functions and statics.)
 - #53740 (add llvm-readobj to llvm-tools-preview)
 - #53743 (fix a typo: taget_env -> target_env)
 - #53747 (Rustdoc fixes)
 - #53753 (expand keep-stage --help text)
 - #53756 (Fix typo in comment)
 - #53768 (move file-extension based .gitignore down to src/)
 - #53785 (Fix a comment in src/libcore/slice/mod.rs)
 - #53786 (Replace usages of 'bad_style' with 'nonstandard_style'.)
 - #53806 (Fix UI issues on Implementations on Foreign types)

Failed merges:

r? @ghost
@bors bors merged commit b73843f into rust-lang:master Aug 31, 2018
@nnethercote nnethercote deleted the inline-shallow_resolve branch August 31, 2018 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants