Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure every unstable language feature has a tracking issue. #51090

Merged
merged 1 commit into from
May 27, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented May 26, 2018

Filled in the missing numbers:

Reused existing tracking issues because they were decomposed from a larger feature

Filed new issues

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2018
@kennytm kennytm changed the title Ensure every unstable feature has a tracking issue. Ensure every unstable language feature has a tracking issue. May 26, 2018
@rust-highfive

This comment has been minimized.

@kennytm kennytm force-pushed the tidy-check-missing-tracking-issue branch from 1bfbf30 to 141399b Compare May 26, 2018 16:49
@rust-highfive

This comment has been minimized.

@kennytm kennytm force-pushed the tidy-check-missing-tracking-issue branch from 141399b to 79e53a3 Compare May 26, 2018 17:43
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 26, 2018

📌 Commit 79e53a3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2018
@bors
Copy link
Contributor

bors commented May 26, 2018

⌛ Testing commit 79e53a3377be86de3177d509d64352b77c717367 with merge 5b01b21079590ee4130e9d797d5b974eb4b595c8...

@bors
Copy link
Contributor

bors commented May 26, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2018
@kennytm kennytm force-pushed the tidy-check-missing-tracking-issue branch from 79e53a3 to 509f414 Compare May 27, 2018 06:22
@kennytm
Copy link
Member Author

kennytm commented May 27, 2018

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented May 27, 2018

📌 Commit 509f414 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2018
@bors
Copy link
Contributor

bors commented May 27, 2018

⌛ Testing commit 509f414 with merge 3fd82a5...

bors added a commit that referenced this pull request May 27, 2018
…lexcrichton

Ensure every unstable language feature has a tracking issue.

Filled in the missing numbers:

* `abi_ptx` → #38788
* `generators` → #43122
* `global_allocator` → #27389

Reused existing tracking issues because they were decomposed from a larger feature

* `*_target_feature` → #44839 (reusing the old `target_feature` number)
* `proc_macros_*` → #38356 (reusing the to-be-stabilized `proc_macros` number)

Filed new issues

* `exhaustive_patterns` → #51085
* `pattern_parentheses` → #51087
* `wasm_custom_section` and `wasm_import_module` → #51088
@bors
Copy link
Contributor

bors commented May 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3fd82a5 to master...

@bors bors merged commit 509f414 into rust-lang:master May 27, 2018
@kennytm kennytm deleted the tidy-check-missing-tracking-issue branch May 27, 2018 09:56
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 6, 2023
…compiler-errors

Issue numbers are enforced on active features; remove FIXME

Since rust-lang#51090 tidy enforces that active features have an issue number, so remove the FIXME.

This PR is part of rust-lang#44366 which is E-help-wanted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants