Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tempdir by tempfile #50698

Merged
merged 4 commits into from
Jun 21, 2018
Merged

Replace tempdir by tempfile #50698

merged 4 commits into from
Jun 21, 2018

Conversation

Eijebong
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:05:13] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:13] tidy error: /checkout/src/librustc_trans/back/link.rs:324: line longer than 100 chars
[00:05:13] tidy error: /checkout/src/librustdoc/test.rs:276: line longer than 100 chars
[00:05:14] Dependencies not on the whitelist:
[00:05:14] * tempfile 
[00:05:14] some tidy checks failed
[00:05:14] 
[00:05:14] 
[00:05:14] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:14] 
[00:05:14] 
[00:05:14] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:14] Build completed unsuccessfully in 0:02:07
[00:05:14] Build completed unsuccessfully in 0:02:07
[00:05:14] Makefile:79: recipe for target 'tidy' failed
[00:05:14] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0aa7edd5
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented May 13, 2018

☔ The latest upstream changes (presumably #50235) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented May 15, 2018

☔ The latest upstream changes (presumably #50769) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
####################################                                      50.8%
#####################################################                     73.6%
######################################################################## 100.0%
[00:01:14] extracting /checkout/obj/build/cache/2018-04-24/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:14] error: failed to parse lock file at: /checkout/src/Cargo.lock
[00:01:14] To learn more, run the command again with --verbose.
[00:01:14] To learn more, run the command again with --verbose.
[00:01:14] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:14] Build completed unsuccessfully in 0:00:19
[00:01:14] make: *** [prepare] Error 1
[00:01:14] Makefile:81: recipe for target 'prepare' failed
[00:01:15] Command failed. Attempt 2/5:
[00:01:15] error: failed to parse lock file at: /checkout/src/Cargo.lock
[00:01:15] To learn more, run the command again with --verbose.
[00:01:15] To learn more, run the command again with --verbose.
[00:01:15] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:15] Build completed unsuccessfully in 0:00:00
[00:01:15] Makefile:81: recipe for target 'prepare' failed
[00:01:15] make: *** [prepare] Error 1
[00:01:17] Command failed. Attempt 3/5:
[00:01:18] error: failed to parse lock file at: /checkout/src/Cargo.lock
[00:01:18] To learn more, run the command again with --verbose.
[00:01:18] To learn more, run the command again with --verbose.
[00:01:18] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:18] Build completed unsuccessfully in 0:00:00
[00:01:18] Makefile:81: recipe for target 'prepare' failed
[00:01:18] make: *** [prepare] Error 1
[00:01:21] Command failed. Attempt 4/5:
[00:01:21] error: failed to parse lock file at: /checkout/src/Cargo.lock
[00:01:21] To learn more, run the command again with --verbose.
[00:01:21] To learn more, run the command again with --verbose.
[00:01:21] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:21] Build completed unsuccessfully in 0:00:00
[00:01:21] make: *** [prepare] Error 1
[00:01:21] Makefile:81: recipe for target 'prepare' failed
[00:01:25] Command failed. Attempt 5/5:
[00:01:25] error: failed to parse lock file at: /checkout/src/Cargo.lock
[00:01:25] To learn more, run the command again with --verbose.
[00:01:25] To learn more, run the command again with --verbose.
[00:01:25] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:25] Build completed unsuccessfully in 0:00:00
[00:01:25] make: *** [prepare] Error 1
[00:01:25] Makefile:81: recipe for target 'prepare' failed
[00:01:25] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:091f21c4
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Eijebong
Copy link
Contributor Author

Welp... Once rustfmt gets updated again, the tempdir dependency will disappear.

@michaelwoerister
Copy link
Member

Thansk, @Eijebong!

@bors r+

@bors
Copy link
Contributor

bors commented May 16, 2018

📌 Commit 5a9e04b has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2018
@michaelwoerister
Copy link
Member

@bors rollup

@bors
Copy link
Contributor

bors commented May 17, 2018

☔ The latest upstream changes (presumably #50615) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 17, 2018
@Eijebong
Copy link
Contributor Author

I rebased, bors didn't remove waiting-on-author for some reasons :)

@kennytm
Copy link
Member

kennytm commented May 19, 2018

@bors r=michaelwoerister rollup-

@bors
Copy link
Contributor

bors commented May 19, 2018

📌 Commit 8f27e6d has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2018
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 7, 2018
@pietroalbini
Copy link
Member

The reviewer is away, maybe someone from @rust-lang/compiler can review this?

@oli-obk
Copy link
Contributor

oli-obk commented Jun 18, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jun 18, 2018

📌 Commit 1fec4af has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2018
@bors
Copy link
Contributor

bors commented Jun 18, 2018

🔒 Merge conflict

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 18, 2018
@pietroalbini
Copy link
Member

@Eijebong you need to rebase on top of the latest master, even if you don't see any conflicts. Sorry for the trouble!

@Eijebong
Copy link
Contributor Author

Done. Sorry for the delay

@kennytm
Copy link
Member

kennytm commented Jun 20, 2018

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jun 20, 2018

📌 Commit c863049 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2018
bors added a commit that referenced this pull request Jun 20, 2018
@bors
Copy link
Contributor

bors commented Jun 20, 2018

⌛ Testing commit c863049 with merge 01172a7...

@bors
Copy link
Contributor

bors commented Jun 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 01172a7 to master...

@bors
Copy link
Contributor

bors commented Jun 21, 2018

⌛ Testing commit c863049 with merge f790780...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants