-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #49924
Rollup of 11 pull requests #49924
Commits on Mar 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 2a5f3ee - Browse repository at this point
Copy the full SHA 2a5f3eeView commit details
Commits on Mar 31, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 8056506 - Browse repository at this point
Copy the full SHA 8056506View commit details
Commits on Apr 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7575d96 - Browse repository at this point
Copy the full SHA 7575d96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d93920 - Browse repository at this point
Copy the full SHA 7d93920View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bf3eb6 - Browse repository at this point
Copy the full SHA 0bf3eb6View commit details
Commits on Apr 11, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7e50039 - Browse repository at this point
Copy the full SHA 7e50039View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34956c8 - Browse repository at this point
Copy the full SHA 34956c8View commit details -
Ignore copyright year when generating deriving span tests
Previously, generate-deriving-span-tests.py would regenerate all the tests anew, even if they hadn't changed. This creates unnecessary diffs that only change the copyright year. Now we check to see if any of the content of the test has changed before generating the new one.
Configuration menu - View commit details
-
Copy full SHA for 0b393e0 - Browse repository at this point
Copy the full SHA 0b393e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ef8493 - Browse repository at this point
Copy the full SHA 2ef8493View commit details
Commits on Apr 12, 2018
-
core: Remove panics from some
Layout
methods`Layout` is often used at the core of allocation APIs and is as a result pretty sensitive to codegen in various circumstances. I was profiling `-C opt-level=z` with a wasm project recently and noticed that the `unwrap()` wasn't removed inside of `Layout`, causing the program to be much larger than it otherwise would be. If inlining were more aggressive LLVM would have figured out that the panic could be eliminated, but in general the methods here can't panic in the first place! As a result this commit makes the following tweaks: * Removes `unwrap()` and replaces it with `unsafe` in `Layout::new` and `Layout::for_value`. For posterity though a debug assertion was left behind. * Removes an `unwrap()` in favor of `?` in the `repeat` method. The comment indicating that the function call couldn't panic wasn't quite right in that if `alloc_size` becomes too large and if `align` is high enough it could indeed cause a panic. This'll hopefully mean that panics never get introduced into code in the first place, ensuring that `opt-level=z` is closer to `opt-level=s` in this regard.
Configuration menu - View commit details
-
Copy full SHA for ec3bccb - Browse repository at this point
Copy the full SHA ec3bccbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d554f4c - Browse repository at this point
Copy the full SHA d554f4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f78b8c0 - Browse repository at this point
Copy the full SHA f78b8c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f711c05 - Browse repository at this point
Copy the full SHA f711c05View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1610ae - Browse repository at this point
Copy the full SHA f1610aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f10146 - Browse repository at this point
Copy the full SHA 6f10146View commit details -
Configuration menu - View commit details
-
Copy full SHA for de34533 - Browse repository at this point
Copy the full SHA de34533View commit details -
Configuration menu - View commit details
-
Copy full SHA for 807c1a0 - Browse repository at this point
Copy the full SHA 807c1a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f60341 - Browse repository at this point
Copy the full SHA 2f60341View commit details
Commits on Apr 13, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 35087fc - Browse repository at this point
Copy the full SHA 35087fcView commit details -
Rollup merge of rust-lang#49396 - Zoxc:sync-on-disk-cache, r=michaelw…
…oerister Make OnDiskCache thread-safer I'm not sure if `synthetic_expansion_infos` is handled correctly. `interpret_alloc_cache` and `interpret_alloc_size` seems to be wrong though, since the code may now decode two `AllocId`s in parallel. I'd like some input on how to fix that. cc @oli-obk r? @michaelwoerister
Configuration menu - View commit details
-
Copy full SHA for 976a17b - Browse repository at this point
Copy the full SHA 976a17bView commit details -
Rollup merge of rust-lang#49626 - fanzier:chalk-lowering, r=scalexm
Implement Chalk lowering rule Normalize-From-Impl This extends the Chalk lowering pass with the "Normalize-From-Impl" rule for generating program clauses from a trait definition as part of rust-lang#49177. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 509ccd6 - Browse repository at this point
Copy the full SHA 509ccd6View commit details -
Rollup merge of rust-lang#49866 - Mark-Simulacrum:pr-travis-windows, …
…r=alexcrichton Cross-compile builder to Windows for PRs on Travis I chose a completely arbitrary windows target here (I have no idea what's best, we could do multiple -- they are relatively fast). r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for f4ac852 - Browse repository at this point
Copy the full SHA f4ac852View commit details -
Rollup merge of rust-lang#49876 - oli-obk:no_secret_clippy_on_stable_…
…☹, r=nrc Don't inject clippy into rls on stable/beta r? @nrc as discussed at the all-hands
Configuration menu - View commit details
-
Copy full SHA for 9dbfcb5 - Browse repository at this point
Copy the full SHA 9dbfcb5View commit details -
Rollup merge of rust-lang#49884 - alexcrichton:less-unwrap, r=Mark-Si…
…mulacrum core: Remove panics from some `Layout` methods `Layout` is often used at the core of allocation APIs and is as a result pretty sensitive to codegen in various circumstances. I was profiling `-C opt-level=z` with a wasm project recently and noticed that the `unwrap()` wasn't removed inside of `Layout`, causing the program to be much larger than it otherwise would be. If inlining were more aggressive LLVM would have figured out that the panic could be eliminated, but in general the methods here can't panic in the first place! As a result this commit makes the following tweaks: * Removes `unwrap()` and replaces it with `unsafe` in `Layout::new` and `Layout::for_value`. For posterity though a debug assertion was left behind. * Removes an `unwrap()` in favor of `?` in the `repeat` method. The comment indicating that the function call couldn't panic wasn't quite right in that if `alloc_size` becomes too large and if `align` is high enough it could indeed cause a panic. This'll hopefully mean that panics never get introduced into code in the first place, ensuring that `opt-level=z` is closer to `opt-level=s` in this regard.
Configuration menu - View commit details
-
Copy full SHA for 09c321c - Browse repository at this point
Copy the full SHA 09c321cView commit details -
Rollup merge of rust-lang#49886 - varkor:generate-deriving-span-tests…
…-usability, r=nikomatsakis Ignore copyright year when generating deriving span tests Previously, generate-deriving-span-tests.py would regenerate all the tests anew, even if they hadn't changed. This creates unnecessary diffs that only change the copyright year. Now we check to see if any of the content of the test has changed before generating the new one.
Configuration menu - View commit details
-
Copy full SHA for 28bf5a3 - Browse repository at this point
Copy the full SHA 28bf5a3View commit details -
Rollup merge of rust-lang#49904 - michaelwoerister:no-debug-attr, r=a…
…lexcrichton Work around LLVM debuginfo problem in librustc_driver. Works around a problem (rust-lang#48910) with global variable debuginfo generation for `rustc_driver::get_trans::LOAD` by applying `#[no_debug]` to it (which just disables debuginfo generation for that variable). This way we can build the compiler with debuginfo again. Since the problem is also present in beta, this workaround might have to be backported. r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for 451cf7c - Browse repository at this point
Copy the full SHA 451cf7cView commit details -
Rollup merge of rust-lang#49908 - chrisccoulson:fix-rustdoc-themes-te…
…st-without-rpath, r=Mark-Simulacrum Fix test failure in src/tools/rustdoc-themes when rust.rpath = false See rust-lang#49907
Configuration menu - View commit details
-
Copy full SHA for 0bf5af0 - Browse repository at this point
Copy the full SHA 0bf5af0View commit details -
Rollup merge of rust-lang#49922 - f-bro:zmiri, r=oli-obk
Remove -Zmiri debugging option ?r @oli-obk
Configuration menu - View commit details
-
Copy full SHA for 5d59264 - Browse repository at this point
Copy the full SHA 5d59264View commit details -
Rollup merge of rust-lang#49916 - llogiq:doc-atomic-fetch-update, r=k…
…ennytm improve Atomic*::fetch_update docs This clarifies that fetch_update *always* returns the previous value, either as `Ok(_)` or `Err(_)`, depending on whether the supplied update function returned `Some(_)` or `None`.
Configuration menu - View commit details
-
Copy full SHA for ba8be1d - Browse repository at this point
Copy the full SHA ba8be1dView commit details -
Rollup merge of rust-lang#49289 - varkor:emit-metadata-without-link, …
…r=michaelwoerister Make --emit=metadata output metadata regardless of link Fixes rust-lang#40109. I'm not sure whether this condition was important here or not, but I can't see why it is required (removing it doesn't cause the error the comment warns about, so I'm assuming it's safe). If this is too heavy-handed, I can special-case on `OutputType::Metadata`.
Configuration menu - View commit details
-
Copy full SHA for f1da9f4 - Browse repository at this point
Copy the full SHA f1da9f4View commit details