Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchors issue when everything is collapsed #49652

Merged
merged 1 commit into from
Apr 7, 2018

Conversation

GuillaumeGomez
Copy link
Member

Fixes #49455.

@frewsxcv does it seem good for you like this?

r? @QuietMisdreavus

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2018
@QuietMisdreavus
Copy link
Member

I'm building some docs with this change, but it looks like this change makes it so that if the URL has an anchor, it doesn't auto-collapse a section that has that anchor in it? Just making sure. It looks good, but i'd like to poke around a rendering with it before giving an r+.

@QuietMisdreavus
Copy link
Member

@frewsxcv Here's a rendering on my server of docs with this change. If this works out for you, r=me.

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, lgtm!

@QuietMisdreavus
Copy link
Member

Cool! Let's get this rolling then. :D

@bors r+

@bors
Copy link
Contributor

bors commented Apr 6, 2018

📌 Commit 238583a has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 6, 2018
…QuietMisdreavus

Fix anchors issue when everything is collapsed

Fixes rust-lang#49455.

@frewsxcv does it seem good for you like this?

r? @QuietMisdreavus
kennytm added a commit to kennytm/rust that referenced this pull request Apr 7, 2018
…QuietMisdreavus

Fix anchors issue when everything is collapsed

Fixes rust-lang#49455.

@frewsxcv does it seem good for you like this?

r? @QuietMisdreavus
bors added a commit that referenced this pull request Apr 7, 2018
Rollup of 9 pull requests

Successful merges:

 - #49510 (Fix anchor position on fields)
 - #49652 (Fix anchors issue when everything is collapsed)
 - #49702 (std: Inline some Termination-related methods)
 - #49728 (add emit_debug_gdb_scripts target option and ..)
 - #49731 (add THUMB targets to rustup manifest)
 - #49742 (Using X headings instead of 0.X #49739)
 - #49748 (proc_macro: Improve Debug representations)
 - #49750 (bootstrap: Remove the fast path)
 - #49503 (Inject the `compiler_builtins` crate whenever the `core` crate is injected)

Failed merges:
@bors bors merged commit 238583a into rust-lang:master Apr 7, 2018
@GuillaumeGomez GuillaumeGomez deleted the anchor-collapsed branch April 7, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants