Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace structurally_resolved_type in casts check. #48270

Merged
merged 3 commits into from
Apr 12, 2018
Merged

Replace structurally_resolved_type in casts check. #48270

merged 3 commits into from
Apr 12, 2018

Commits on Mar 22, 2018

  1. Replace structurally_resolved_type in casts check. 

    The behaviour of `resolve_type_vars_if_possible` is simpler and
infallible.
    @leoyvens
    leoyvens committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    7719f53 View commit details
    Browse the repository at this point in the history

  2. Replace structurally_resolve_type in unary expr check. 

    `resolve_type_vars_with_obligations` is the same but doesn't error on unresolved type variables.
In theory this could make more code compile because we don't error or could ommit an otherwise useful error.
In practice I couldn't observe any effect.
    @leoyvens
    leoyvens committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    7353ef7 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2018

  1. revert making casts atomic, test order dependency

    @leoyvens
    leoyvens committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    0a5a5c3 View commit details
    Browse the repository at this point in the history