Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Travis CI macOS images for testing from Xcode 8.3 to 9.2. #48114

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Feb 10, 2018

Retry of #47749, since LLVM 6 has been merged.

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 10, 2018
@alexcrichton
Copy link
Member

Restarted jobs because they timed out presumably warming caches

@kennytm
Copy link
Member Author

kennytm commented Feb 10, 2018

Still timed out, I guess timed-out builds won't get cached, but it basically worked.

@alexcrichton
Copy link
Member

Oh I think I may have actually missed this before but is it required that MACOSX_DEPLOYMENT_TARGET changes? Ideally that's as low as it can be and it may be a breaking change to raise it.

@kennytm
Copy link
Member Author

kennytm commented Feb 10, 2018

@alexcrichton The dist ones remain the same. But let me try to lower it and see...

@alexcrichton
Copy link
Member

Looks like the same timeout, but r=me otherwise!

@kennytm
Copy link
Member Author

kennytm commented Feb 11, 2018

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Feb 11, 2018

📋 Looks like this PR is still in progress, ignoring approval

@kennytm kennytm changed the title [WIP] Upgrade the Travis CI macOS images for testing from Xcode 8.3 to 9.2. Upgrade the Travis CI macOS images for testing from Xcode 8.3 to 9.2. Feb 11, 2018
@kennytm
Copy link
Member Author

kennytm commented Feb 11, 2018

Oops sorry.

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Feb 11, 2018

📌 Commit bf69b0f has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 12, 2018
…ade the Travis CI macOS images for testing from Xcode 8.3 to 9.2. Retry of rust-lang#47749, since LLVM 6 has been merged.
bors added a commit that referenced this pull request Feb 12, 2018
Rollup of 8 pull requests

- Successful merges: #47846, #48033, #48087, #48114, #48126, #48130, #48133, #48151
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 13, 2018
Upgrade the Travis CI macOS images for testing from Xcode 8.3 to 9.2.

Retry of rust-lang#47749, since LLVM 6 has been merged.
bors added a commit that referenced this pull request Feb 13, 2018
Rollup of 14 pull requests

- Successful merges: #47784, #47846, #48033, #48083, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48163, #48165, #48167
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 14, 2018
Upgrade the Travis CI macOS images for testing from Xcode 8.3 to 9.2.

Retry of rust-lang#47749, since LLVM 6 has been merged.
bors added a commit that referenced this pull request Feb 14, 2018
bors added a commit that referenced this pull request Feb 15, 2018
bors added a commit that referenced this pull request Feb 15, 2018
@kennytm kennytm merged commit bf69b0f into rust-lang:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants