Fix overflow when performing drop check calculations in NLL #47920
Conversation
Clearing out the infcx's region constraints after processing each type ends up interacting badly with normalizing associated types. This commit keeps all region constraints intact until the end of TypeLivenessGenerator.add_drop_live_constraint, ensuring that normalized types are able to re-use existing inference variables. Fixes rust-lang#47589
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
kennytm
added
the
S-waiting-on-review
|
@bors r+ -- this may be a perf win as well |
|
📌 Commit 0fd4f37 has been approved by |
nikomatsakis
added
S-waiting-on-bors
| @@ -15,7 +15,11 @@ use dataflow::move_paths::{HasMoveData, MoveData}; | |||
| use rustc::mir::{BasicBlock, Location, Mir}; | |||
| use rustc::mir::Local; | |||
| use rustc::ty::{self, Ty, TyCtxt, TypeFoldable}; | |||
| //use rustc::ty::subst::Kind; | |||
|
@bors r- |
|
@Mark-Simulacrum: Fixed |
|
@bors r+ |
|
📌 Commit a7646df has been approved by |
Fix overflow when performing drop check calculations in NLL Clearing out the infcx's region constraints after processing each type ends up interacting badly with normalizing associated types. This commit keeps all region constraints intact until the end of TypeLivenessGenerator.add_drop_live_constraint, ensuring that normalized types are able to re-use existing inference variables. Fixes #47589
|
☀️ Test successful - status-appveyor, status-travis |
Clearing out the infcx's region constraints after processing each type
ends up interacting badly with normalizing associated types. This commit
keeps all region constraints intact until the end of
TypeLivenessGenerator.add_drop_live_constraint, ensuring that normalized
types are able to re-use existing inference variables.
Fixes #47589