Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 47738 to beta #47918

Merged
merged 4 commits into from
Feb 2, 2018
Merged

Backport 47738 to beta #47918

merged 4 commits into from
Feb 2, 2018

Conversation

nikomatsakis
Copy link
Contributor

Backport of #47738 to beta branch.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 1, 2018
@nikomatsakis
Copy link
Contributor Author

@bors r=eddyb

This was already approved in #47738, this is just a clean rebase onto beta.

@bors
Copy link
Contributor

bors commented Feb 1, 2018

📌 Commit 3bda277 has been approved by eddyb

@kennytm
Copy link
Member

kennytm commented Feb 1, 2018

@bors p=2

Beta backport.

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2018
@bors
Copy link
Contributor

bors commented Feb 1, 2018

⌛ Testing commit 3bda277 with merge 2887ba617ebcd471f9b66d01b5c9b358fd1cf801...

@bors
Copy link
Contributor

bors commented Feb 1, 2018

💔 Test failed - status-appveyor

@kennytm
Copy link
Member

kennytm commented Feb 2, 2018

@bors retry #46903

@bors
Copy link
Contributor

bors commented Feb 2, 2018

⌛ Testing commit 3bda277 with merge 61bc3af...

bors added a commit that referenced this pull request Feb 2, 2018
Backport 47738 to beta

Backport of #47738 to beta branch.
@bors
Copy link
Contributor

bors commented Feb 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 61bc3af to beta...

@bors bors merged commit 3bda277 into rust-lang:beta Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants