Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto: Use x86-64 CABI for foreign function on arm target #4781

Merged
merged 1 commit into from
Feb 5, 2013

Conversation

ILyoan
Copy link
Contributor

@ILyoan ILyoan commented Feb 4, 2013

Fixed CABI problem on arm target.

Related issue: #4513
Related commit:

@graydon
Copy link
Contributor

graydon commented Feb 4, 2013

I'm a little confused about this; is the ARM ABI really so similar to x64 that it can use the same definition here?

@bors bors closed this Feb 5, 2013
@bors bors merged commit 6105f09 into rust-lang:incoming Feb 5, 2013
@ILyoan
Copy link
Contributor Author

ILyoan commented Feb 5, 2013

@graydon I'm also worried about this.
It's much similar than default setting and it seems like to run pretty well with x86_64 ABI but I don't think these two ABIs are exactly the same; I think we need to implement cabi_arm.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants