[WIP] Upgrade to and test LLVM 6 #47681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like they did some refactoring of flags in the backend and this should catch us up!
Apparently LLVM also removed it!
Treat it similarly in Rust!
Now it just returns an `Error`
LLVM <= 4.0 used a non-standard interpretation of `DW_OP_plus`. In the DWARF standard, this adds two items on the expressions stack. LLVM's behavior was more like DWARF's `DW_OP_plus_uconst` -- adding a constant that follows the op. The patch series starting with [D33892] switched to the standard DWARF interpretation, so we need to follow. [D33892]: https://reviews.llvm.org/D33892
Some assertions in LLVM were popping up for the wasm backend, so this updates the fat LTO backend to do the same thing as ThinLTO, which is to merge all the DICompileUnit instances after merging all modules into one.
Apparently the `lib.exe` behavior added in llvm-mirror/llvm@0e34c359 is causing breakage when attempting to link in `librustc_binaryen.rlib`, so let's see if this fixes it.
* Don't compile usage of `clearOperands` * Conditionally use an optional code model
we know it's gonna fail
kennytm
added
the
S-waiting-on-author
18 tasks
Looksl ike the clang with 16.04 fails to compile LLVM 6, but it looks like clang in 18.04 can indeed compile LLVM 6.
|
Ok testing's done, I'll clean this up and resubmit a PR soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty unlikely to ladn any time soon, but I'd like to start testing this now while we can using travis, so using a PR to do that.