Rollup of 10 pull requests #47622
Merged
Rollup of 10 pull requests #47622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These impls are useful when working with combinator methods that expect an option or a result, but you have a Result<Option<T>, E> instead of an Option<Result<T, E>> or vice versa.
removed styling of dt tages, which would make them look like keys and added <kbd> tag inside of dt tag. Added css style for kbd and removed some stylings for dt
Affected methods are `starts_with` and `strip_prefix`.
We intended to do this quite a while ago but it snuck through.
Though some parts of rust use cc-rs to invoke a compiler/linker, Cargo seems to make use of the TargetOptions::linker property. Make the out of the box experience for CloudABI a bit better by using the same compiler name as cc-rs.
Focus on the ordering/range benefit.
- use consistent phrasing for expected and found arguments - suggest changing arugments to tuple if possible - suggest changing single tuple argument to arguments if possible
…laumeGomez add kbd style tag to main.css in rustdoc Added css style for kbd tags so they actually look like keys. Result preview and discussion was going on in rust-lang#46900 .
Add transpose conversions for nested Option and Result These impls are useful when working with combinator methods that expect an option or a result, but you have a `Result<Option<T>, E>` instead of an `Option<Result<T, E>>` or vice versa.
…eveklabnik add Rust By Example to the bookshelf cc rust-lang#46194 With rust-lang#46196 freshly merged, we should add a link to the main docs distribution so people can find it! We discussed this at the docs team meeting today and decided to go ahead with adding it to the bookshelf.
Deprecate std::net::lookup_host We intended to do this quite a while ago but it snuck through. r? @alexcrichton
Add some edge cases to the documentation of `Path` Affected methods are `starts_with` and `strip_prefix`.
add target/ to ignored tidy dirs Sometimes you get a target directory from running cargo in the rust repo (the root is `src/`), and it contains generated files. Just whitelist it since it causes tidy to spew warnings uncontrollably.
Fix the "Github - About Pull Requests" link in CONTRIBUTING.md Previously the text that is supposed to link to the Github Pull Requests page, instead linked to the same file (CONTRIBUTING.md).
…richton Give TargetOptions::linker a sane default value for CloudABI. Though some parts of rust use cc-rs to invoke a compiler/linker, Cargo seems to make use of the TargetOptions::linker property. Make the out of the box experience for CloudABI a bit better by using the same compiler name as cc-rs.
Closure argument mismatch tweaks - use consistent phrasing for expected and found arguments - suggest changing arguments to tuple if possible - suggest changing single tuple argument to arguments if possible Fix rust-lang#44150.
Update BTreeMap recommendation Focus on the ordering / range(instead of all) benefit as it's the most important feature.
|
Some changes occurred in HTML/CSS. |
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 4074893 has been approved by |
|
⌛ Testing commit 4074893 with merge 0af40b6d4ae09033e76cd07439cfff2dd5469ed2... |
|
💔 Test failed - status-appveyor |
|
@bors retry appveyor timeout |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path#47532, add target/ to ignored tidy dirs #47535, Fix the "Github - About Pull Requests" link in CONTRIBUTING.md #47559, Give TargetOptions::linker a sane default value for CloudABI. #47568, Closure argument mismatch tweaks #47573, Update BTreeMap recommendation #47578