Teach rustc about DW_AT_noreturn and a few more DIFlags #47618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrhota
force-pushed
the
dw_at_noreturn
branch
from
d1ac357
to
f7f6598
Compare
|
i'm not sure why test fails on travis. it passes locally when I run the individual test and |
kennytm
reviewed
Jan 21, 2018
src/rustllvm/RustWrapper.cpp
Outdated
| @@ -545,6 +549,18 @@ static unsigned fromRust(LLVMRustDIFlags Flags) { | |||
| Result |= DINode::DIFlags::FlagRValueReference; | |||
| } | |||
| #if LLVM_RUSTLLVM || LLVM_VERSION_GE(4, 0) | |||
There was a problem hiding this comment.
i'm not sure why test fails on travis.
The CI uses the system LLVM 3.9 for testing, so both conditions are going to be false, meaning these flags won't be applied at all.
You may move these flags into another #if block which does not check LLVM_RUSTLLVM (assume these can apply to the unmodified LLVM), or tag the test case with // no-system-llvm.
kennytm
added
the
S-waiting-on-review
|
📌 Commit e0f9b26 has been approved by |
kennytm
added
S-waiting-on-bors
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 25, 2018
…rister Teach rustc about DW_AT_noreturn and a few more DIFlags We achieve two small things with this PR: 1. We provide definitions for a few additional llvm debuginfo flags 1. We _use_ one of these new flags, `FlagNoReturn`, and add it to debuginfo for functions with the never return type (`!`).
bors
added a commit
that referenced
this pull request
Jan 26, 2018
|
☔ The latest upstream changes (presumably #47748) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We achieve two small things with this PR:
FlagNoReturn, and add it to debuginfo for functions with the never return type (!).