Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clippy #47557

Closed
wants to merge 1 commit into from
Closed

Update clippy #47557

wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 18, 2018

r? @Manishearth

cc @kennytm

supersedes #47172 by not running dogfood in the rustc test suite and placing the clippy ui output files into /tmp

@kennytm
Copy link
Member

kennytm commented Jan 18, 2018

[00:02:53] Makefile:76: recipe for target 'prepare' failed
[00:02:53] Command failed. Attempt 5/5:
[00:02:53]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:53] error: failed to select a version for `compiletest_rs` (required by `miri`):
[00:02:53] all possible versions conflict with previously selected versions of `compiletest_rs`
[00:02:53]   version 0.3.5 in use by compiletest_rs v0.3.5
[00:02:53]   possible versions to select: 0.3.3
[00:02:53] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked

Please do a cargo update.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 18, 2018

I did. It's conflicting with miri. But I can't update just the Cargo.toml of miri, I need to get it working again before it'll allow me to merge ;)

@Manishearth
Copy link
Member

r=me when you fix the build

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2018
@carols10cents carols10cents mentioned this pull request Jan 22, 2018
@shepmaster
Copy link
Member

Ping from triage @oli-obk ! We haven't heard from you in a week; will you be able to "get it working again" in the near future? 😇

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 29, 2018

Yea this'll be stuck a while longer

@oli-obk oli-obk closed this Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants