Stabilize allow_fail flag test feature #46501
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
force-pushed
the
allow-fail-stabilization
branch
2 times, most recently
from
d336766
to
c146537
Compare
kennytm
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #46528) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
allow-fail-stabilization
branch
from
c146537
to
90a746f
Compare
|
Rebased. |
|
review ping for you @michaelwoerister ! |
|
I don't really know about this. r? @nrc |
nrc
added
I-nominated
S-waiting-on-team
|
I think this needs some discussion before stabilisation - there was quite a lot of discussion on the original PR about whether this was a good idea or not, and I don't see any indication that this feature has proved itself in the meantime. Let's discuss at the next dev-tools meeting. |
|
Triage ping @rust-lang/dev-tools! Has this been discussed and is there a conclusion on this PR? |
src/libsyntax/feature_gate.rs
Outdated
| @@ -519,6 +516,8 @@ declare_features! ( | |||
| // Allows the sysV64 ABI to be specified on all platforms | |||
| // instead of just the platforms on which it is the C ABI | |||
| (accepted, abi_sysv64, "1.24.0", Some(36167)), | |||
| // Allows a test to fail without failing the whole suite | |||
| (accepted, allow_fail, "1.23.0", Some(42219)), | |||
There was a problem hiding this comment.
just a quick note: this should be ≥1.25.0 by now
|
@kennytm: The meeting is tomorrow so I hope we'll discuss it at this time. |
GuillaumeGomez
force-pushed
the
allow-fail-stabilization
branch
from
90a746f
to
c14140e
Compare
|
Discussed at dev-tools meeting, we plan not to stabilise this feature |
apiraino
removed
the
S-waiting-on-team
Fixes #46488.