Rollup of 11 pull requests #44678
Merged
Rollup of 11 pull requests #44678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove a period on a different help line for consistency
This seems to have been undocumented. Mention this where the name is set (Builder::name) and where the panic could happen (Builder::spawn). Thread::new is private and I think the builder is the only user where this matters. A short comment was added to "document" Thread::new too.
After the following conversation in #rust-lang: ``` [14:43:50] <Ixrec> TIL the implementation of from_utf_unchecked is literally just "mem::transmute(x)" [14:43:59] <Ixrec> no wonder people keep saying transmute is overpowered [15:15:30] <eddyb> Ixrec: it should be a pointer cast lol [15:15:46] <eddyb> unless it doesn't let you [16:50:34] <Ixrec> https://play.rust-lang.org/?gist=d1e6b629ad9ec1baf64ce261c63845e6&version=stable seems like it does let me [16:52:35] <eddyb> Ixrec: yeah that's the preferred impl [16:52:46] <eddyb> Ixrec: it just wasn't in 1.0 [16:52:50] <eddyb> IIRC [16:53:00] <eddyb> (something something fat pointers) ``` Since I already wrote half of the preferred impls in the playground, might as well make an actual PR.
These Region values end up in crate metadata so they should not use NodeId.
This makes sure that we don't introduce strange cases where we have nodes outside the query system that could break red/green tracking and it will allow to keep red/green neatly encapsulated within the DepGraph implementation.
- Don't hash traits in scope as part of HIR hashing any more. - Some queries returned DefIndexes from other crates. - Provide a generic way of stably hashing maps (not used everywhere yet).
…n't have to be hashed in downstream crates.
…s2, r=nikomatsakis incr.comp.: Compute fingerprint for all query results. This PR enables query result fingerprinting in incremental mode. This is an essential piece of infrastructure for red/green tracking. We don't do anything with the fingerprints yet but merging the infrastructure should protect it from bit-rotting and will make it easier to start measuring its performance impact (and thus let us determine if we should switch to a faster hashing algorithm rather sooner than later). Note, this PR also includes the changes from rust-lang#43887 which I'm therefore closing. No need to re-review the first commit though. r? @nikomatsakis
Add Cow<str> -> Box<Error> impls. Considering how impls exist for `String` and `&str`, it makes sense to also add an impl for `Cow<str>` as well. This would allow converting `String::from_utf8_lossy` directly into a `Box<Error>` or `io::Error` without having to add an extra `into_ownd()`.
More `align_offset` things cc rust-lang#44488
Add proper help line for `-C inline threshold` Looks like someone accidentally some words when adding this. This also remove a period on a different help line for consistency, as no options have a period.
Stabilized vec_splice and modified splice tracking issue This stabilizes the vec_splice (Vec part of splice RFC) Fixes rust-lang#32310.
… r=steveklabnik Document thread builder panics for nul bytes in thread names This seems to have been undocumented. Mention this where the name is set (Builder::name) and where the panic could happen (Builder::spawn). Thread::new is private and I think the builder is the only user where this matters. A short comment was added to "document" Thread::new too.
|
@bors: r+ p=10 |
|
📌 Commit bbaf61f has been approved by |
|
⌛ Testing commit bbaf61f1a9513e9dfcbf1f75bbf46930063b45a6 with merge 3cf5733f321fdbcb058d1db8a95e4e4b21aa140c... |
carols10cents
added
the
S-waiting-on-bors
|
💔 Test failed - status-appveyor |
|
|
alexcrichton
force-pushed
the
rollup
branch
from
bbaf61f
to
929215d
Compare
|
@bors: r+ p=10 |
|
📌 Commit 929215d has been approved by |
|
@bors: r+ p=10 |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 929215d has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Sep 18, 2017
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
align_offsetthings #44537, Add proper help line for-C inline threshold#44548, Stabilized vec_splice and modified splice tracking issue #44640, Document thread builder panics for nul bytes in thread names #44651, Replace str's transmute() calls with pointer casts #44657, Add more links and put the link character to the left #44661, Add Example ofIntoIteratoras Trait Bound to Docs #44668, Fix run button #44671, ci: Use multiple codegen units on non-dist bots #44675