-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 25 pull requests #44623
Rollup of 25 pull requests #44623
Commits on Sep 3, 2017
-
alloc: Implement downcast Rc<Any> -> Rc<T>
Implement downcast the like it exists for Box. The implementation avoids using into_raw/from_raw, because the pointer arithmetic which should cancel does not seem to optimize out at the moment. Since Rc<T> is never Send, only Rc<Any> and not Rc<Any + Send> implements downcast.
Configuration menu - View commit details
-
Copy full SHA for 758a0ce - Browse repository at this point
Copy the full SHA 758a0ceView commit details
Commits on Sep 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c22db3d - Browse repository at this point
Copy the full SHA c22db3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad170f2 - Browse repository at this point
Copy the full SHA ad170f2View commit details
Commits on Sep 9, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 8b6122f - Browse repository at this point
Copy the full SHA 8b6122fView commit details
Commits on Sep 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for a095ee4 - Browse repository at this point
Copy the full SHA a095ee4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c12e5d - Browse repository at this point
Copy the full SHA 9c12e5dView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 79f888d - Browse repository at this point
Copy the full SHA 79f888dView commit details
Commits on Sep 12, 2017
-
On Windows, the gcc crate would send /Wall to msvc, which would cause builds to get flooded with warnings, exploding compile times from one hour to more than 72! The gcc crate version 0.3.54 changes this behavior to send /W4 instead, which greatly cuts down on cl.exe flooding the command prompt window with warnings.
Configuration menu - View commit details
-
Copy full SHA for 81ebab6 - Browse repository at this point
Copy the full SHA 81ebab6View commit details
Commits on Sep 13, 2017
-
Configuration menu - View commit details
-
Copy full SHA for db65375 - Browse repository at this point
Copy the full SHA db65375View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18ab95f - Browse repository at this point
Copy the full SHA 18ab95fView commit details -
rustc: Spawn
cmd /c emcc.bat
explicitlyIn rust-lang#42436 the behavior for spawning processes on Windows was tweaked slightly to fix various bugs, but this caused rust-lang#42791 as a regression, namely that to spawn batch scripts they need to be manually spawned with `cmd /c` instead now. This updates the compiler to handle this case explicitly for Emscripten. Closes rust-lang#42791
Configuration menu - View commit details
-
Copy full SHA for 5cad391 - Browse repository at this point
Copy the full SHA 5cad391View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2184663 - Browse repository at this point
Copy the full SHA 2184663View commit details
Commits on Sep 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d3bbce7 - Browse repository at this point
Copy the full SHA d3bbce7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3c2386 - Browse repository at this point
Copy the full SHA d3c2386View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8df89a - Browse repository at this point
Copy the full SHA f8df89aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 696a268 - Browse repository at this point
Copy the full SHA 696a268View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39c9a3d - Browse repository at this point
Copy the full SHA 39c9a3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9240454 - Browse repository at this point
Copy the full SHA 9240454View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06478d1 - Browse repository at this point
Copy the full SHA 06478d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1462cab - Browse repository at this point
Copy the full SHA 1462cabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5229443 - Browse repository at this point
Copy the full SHA 5229443View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4253a41 - Browse repository at this point
Copy the full SHA 4253a41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 509982c - Browse repository at this point
Copy the full SHA 509982cView commit details -
travis: Move sccache to the us-west-1 region
Most of the other rust-lang buckets are in us-west-1 and I think the original bucket was just accidentally created in the us-east-1 region. Let's consolidate by moving it to the same location as the rest of our buckets.
Configuration menu - View commit details
-
Copy full SHA for ddd321d - Browse repository at this point
Copy the full SHA ddd321dView commit details -
Customize
<FlatMap as Iterator>::fold
`FlatMap` can use internal iteration for its `fold`, which shows a performance advantage in the new benchmarks: test iter::bench_flat_map_chain_ref_sum ... bench: 4,354,111 ns/iter (+/- 108,871) test iter::bench_flat_map_chain_sum ... bench: 468,167 ns/iter (+/- 2,274) test iter::bench_flat_map_ref_sum ... bench: 449,616 ns/iter (+/- 6,257) test iter::bench_flat_map_sum ... bench: 348,010 ns/iter (+/- 1,227) ... where the "ref" benches are using `by_ref()` that isn't optimized. So this change shows a decent advantage on its own, but much more when combined with a `chain` iterator that also optimizes `fold`.
Configuration menu - View commit details
-
Copy full SHA for 61a7703 - Browse repository at this point
Copy the full SHA 61a7703View commit details
Commits on Sep 15, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 2bde694 - Browse repository at this point
Copy the full SHA 2bde694View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d5b0e1 - Browse repository at this point
Copy the full SHA 9d5b0e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fe4612 - Browse repository at this point
Copy the full SHA 3fe4612View commit details -
rustc: Preallocate when building the dep graph
This commit alters the `query` function in the dep graph module to preallocate memory using `with_capacity` instead of relying on automatic growth. Discovered in rust-lang#44576 it was found that for the syntex_syntax clean incremental benchmark the peak memory usage was found when the dep graph was being saved, particularly the `DepGraphQuery` data structure itself. PRs like rust-lang#44142 which add more queries end up just making this much larger! I didn't see an immediately obvious way to reduce the size of the `DepGraphQuery` object, but it turns out that `with_capacity` helps quite a bit! Locally 831 MB was used [before] this commit, and 770 MB is in use at the peak of the compiler [after] this commit. That's a nice 7.5% improvement! This won't quite make up for the losses in rust-lang#44142 but I figured it's a good start. [before]: https://gist.github.com/alexcrichton/2d2b9c7a65503761925c5a0bcfeb0d1e [before]: https://gist.github.com/alexcrichton/6da51f2a6184bfb81694cc44f06deb5b
Configuration menu - View commit details
-
Copy full SHA for a7817dd - Browse repository at this point
Copy the full SHA a7817ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07494ec - Browse repository at this point
Copy the full SHA 07494ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b571a0 - Browse repository at this point
Copy the full SHA 1b571a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5398e03 - Browse repository at this point
Copy the full SHA 5398e03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90dddf4 - Browse repository at this point
Copy the full SHA 90dddf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2819122 - Browse repository at this point
Copy the full SHA 2819122View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a01dc4 - Browse repository at this point
Copy the full SHA 9a01dc4View commit details -
stabilized iterator_for_each (closes rust-lang#42986)
updated clippy and rls as it uses the iterator_for_each
Configuration menu - View commit details
-
Copy full SHA for 8772227 - Browse repository at this point
Copy the full SHA 8772227View commit details -
Make cargotest run
cargo test --all
instead ofcargo test
,… to support Cargo workspaces.
Configuration menu - View commit details
-
Copy full SHA for 41c3dc5 - Browse repository at this point
Copy the full SHA 41c3dc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7bfa2f - Browse repository at this point
Copy the full SHA e7bfa2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 033d7f6 - Browse repository at this point
Copy the full SHA 033d7f6View commit details -
rustbuild: Update
cmake
dependencyShould help suppress some warnings from various repos as `cmake` in the newest version disables warnings by default.
Configuration menu - View commit details
-
Copy full SHA for 6fdadaa - Browse repository at this point
Copy the full SHA 6fdadaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a39d95 - Browse repository at this point
Copy the full SHA 3a39d95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 351f56a - Browse repository at this point
Copy the full SHA 351f56aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7e974e - Browse repository at this point
Copy the full SHA f7e974eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a589684 - Browse repository at this point
Copy the full SHA a589684View commit details -
rustbuild: Fix test "test rustdoc" invocation
Previously it would use the librustc output directory which would cause rustdoc to get entirely recompiled, whereas the intention is that it uses the already-compiled artifacts from building rustdoc itself, using the tool output directory
Configuration menu - View commit details
-
Copy full SHA for 3da54fb - Browse repository at this point
Copy the full SHA 3da54fbView commit details
Commits on Sep 16, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5ff7064 - Browse repository at this point
Copy the full SHA 5ff7064View commit details -
Rollup merge of rust-lang#44273 - bluss:rc-downcast, r=alexcrichton
Implement <Rc<Any>>::downcast * Implement `<Rc<Any>>::downcast::<T>` * New unstable method. Works just like Box\<Any\>, but for Rc. * Any has two cases for its methods: Any and Any + Send; Rc is never Send, so that case is skipped for Rc. * Motivation for being a method with self is to match Box and there is no user-supplied type; the inner type is Any and downcast does not conflict with any method of Any. * Arc was skipped because Any itself has no downcast for the case that makes most sense: Any + Send + Sync
Configuration menu - View commit details
-
Copy full SHA for d04449b - Browse repository at this point
Copy the full SHA d04449bView commit details -
Rollup merge of rust-lang#44356 - nrc:rls-component-manifest, r=@alex…
…crichton Attempt to fix the component manifest problem for rls-preview cc rust-lang#44270 See rust-lang#44270
Configuration menu - View commit details
-
Copy full SHA for ac3ac7c - Browse repository at this point
Copy the full SHA ac3ac7cView commit details -
Rollup merge of rust-lang#44395 - jcdyer:ip-constructors, r=alexcrichton
Ipv4Addr and Ipv6Addr convenience constructors. Introduce convenience constructors for common types. This introduces the following constructors: * Ipv6Addr::localhost() * Ipv6Addr::unspecified() * Ipv4Addr::localhost() * Ipv4Addr::unspecified() The recently added `From` implementations were nice for avoiding the fallibility of conversions from strings like `"127.0.0.1".parse().unwrap()`, and `"::1".parse().unwrap()`, but while the Ipv4 version is roughly comparable in verbosity, the Ipv6 version lacks zero-segment elision, which makes it significantly more awkward: `[0, 0, 0, 0, 0, 0, 0, 0].into()`. While there isn't a clear way to introduce zero elision to type that can infallibly be converted into Ipv6 addresses, this PR resolves the problem for the two most commonly used addresses, which, incidentally, are the ones that suffer the most from the lack of zero-segment elision. This change is dead simple, and introduces no backwards incompatibility. See also, [this topic on the inernals board](https://internals.rust-lang.org/t/pre-rfc-convenience-ip-address-constructors/5878)
Configuration menu - View commit details
-
Copy full SHA for 9ac81ba - Browse repository at this point
Copy the full SHA 9ac81baView commit details -
Rollup merge of rust-lang#44397 - GuillaumeGomez:codeblock-color, r=Q…
…uietMisdreavus Codeblock color <img width="1440" alt="screen shot 2017-09-07 at 21 53 58" src="https://user-images.githubusercontent.com/3050060/30183045-4319108e-9419-11e7-98da-da54952cab37.png"> This screenshot has been generated from: ```rust /// foo /// /// ```compile_fail /// foo(); /// ``` /// /// ```ignore /// goo(); /// ``` /// /// ``` /// let x = 0; /// ``` pub fn bar() -> usize { 2 } ``` r? @QuietMisdreavus cc @rust-lang/docs
Configuration menu - View commit details
-
Copy full SHA for 8ce5a59 - Browse repository at this point
Copy the full SHA 8ce5a59View commit details -
Rollup merge of rust-lang#44515 - tamird:clean-shims, r=alexcrichton
{compiler-builtins,libc} shim cleanup ~~Depends on rust-lang/libc#764; opening early for feedback.~~ r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for d658e4a - Browse repository at this point
Copy the full SHA d658e4aView commit details -
Rollup merge of rust-lang#44531 - QuietMisdreavus:bump-gcc, r=alexcri…
…chton bump gcc for bootstrap On Windows, the gcc crate would send /Wall to msvc, which would cause builds to get flooded with warnings, exploding compile times from one hour to more than 72! The gcc crate version 0.3.54 changes this behavior to send /W4 instead, which greatly cuts down on cl.exe flooding the command prompt window with warnings.
Configuration menu - View commit details
-
Copy full SHA for 5690502 - Browse repository at this point
Copy the full SHA 5690502View commit details -
Rollup merge of rust-lang#44537 - oli-obk:memchr, r=alexcrichton
More `align_offset` things cc rust-lang#44488
Configuration menu - View commit details
-
Copy full SHA for 458c805 - Browse repository at this point
Copy the full SHA 458c805View commit details -
Rollup merge of rust-lang#44542 - alexcrichton:fix-windows-emscripten…
…, r=nikomatsakis rustc: Spawn `cmd /c emcc.bat` explicitly In rust-lang#42436 the behavior for spawning processes on Windows was tweaked slightly to fix various bugs, but this caused rust-lang#42791 as a regression, namely that to spawn batch scripts they need to be manually spawned with `cmd /c` instead now. This updates the compiler to handle this case explicitly for Emscripten. Closes rust-lang#42791
Configuration menu - View commit details
-
Copy full SHA for 6501701 - Browse repository at this point
Copy the full SHA 6501701View commit details -
Rollup merge of rust-lang#44549 - gaurikholkar:master, r=arielb1
extend E0623 for earlybound and latebound for structs This fixes rust-lang#44508 r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for eccc251 - Browse repository at this point
Copy the full SHA eccc251View commit details -
Rollup merge of rust-lang#44560 - qmx:import-TyCtxt, r=eddyb
bring TyCtxt into scope got comments both from @eddyb and @nikomatsakis (via rust-lang#44505) that we should always put `TyCtxt` in scope should I just go and import it at other places in the codebase or we just keep doing small improvements?
Configuration menu - View commit details
-
Copy full SHA for 6b9bbd7 - Browse repository at this point
Copy the full SHA 6b9bbd7View commit details -
Rollup merge of rust-lang#44562 - eddyb:ugh-rustdoc, r=nikomatsakis
rustdoc: pretty-print Unevaluated expressions in types. Fixes rust-lang#44555. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 143e236 - Browse repository at this point
Copy the full SHA 143e236View commit details -
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,…
… r=alexcrichton stabilized iterator_for_each (closes rust-lang#42986) Also updated clippy and rls as these use the iterator_for_each I've made my first PR's today so most likely I've done something wrong. Sorry about that!
Configuration menu - View commit details
-
Copy full SHA for 20ae064 - Browse repository at this point
Copy the full SHA 20ae064View commit details -
Rollup merge of rust-lang#44574 - alexcrichton:new-sccache-region, r=…
…aidanhs travis: Move sccache to the us-west-1 region Most of the other rust-lang buckets are in us-west-1 and I think the original bucket was just accidentally created in the us-east-1 region. Let's consolidate by moving it to the same location as the rest of our buckets.
Configuration menu - View commit details
-
Copy full SHA for c6451f1 - Browse repository at this point
Copy the full SHA c6451f1View commit details -
Rollup merge of rust-lang#44577 - cuviper:flat_map-fold, r=alexcrichton
Customize `<FlatMap as Iterator>::fold` `FlatMap` can use internal iteration for its `fold`, which shows a performance advantage in the new benchmarks: test iter::bench_flat_map_chain_ref_sum ... bench: 4,354,111 ns/iter (+/- 108,871) test iter::bench_flat_map_chain_sum ... bench: 468,167 ns/iter (+/- 2,274) test iter::bench_flat_map_ref_sum ... bench: 449,616 ns/iter (+/- 6,257) test iter::bench_flat_map_sum ... bench: 348,010 ns/iter (+/- 1,227) ... where the "ref" benches are using `by_ref()` that isn't optimized. So this change shows a decent advantage on its own, but much more when combined with a `chain` iterator that also optimizes `fold`.
Configuration menu - View commit details
-
Copy full SHA for 10e6625 - Browse repository at this point
Copy the full SHA 10e6625View commit details -
Rollup merge of rust-lang#44586 - alexcrichton:smaller-query, r=micha…
…elwoerister rustc: Preallocate when building the dep graph This commit alters the `query` function in the dep graph module to preallocate memory using `with_capacity` instead of relying on automatic growth. Discovered in rust-lang#44576 it was found that for the syntex_syntax clean incremental benchmark the peak memory usage was found when the dep graph was being saved, particularly the `DepGraphQuery` data structure itself. PRs like rust-lang#44142 which add more queries end up just making this much larger! I didn't see an immediately obvious way to reduce the size of the `DepGraphQuery` object, but it turns out that `with_capacity` helps quite a bit! Locally 831 MB was used [before] this commit, and 770 MB is in use at the peak of the compiler [after] this commit. That's a nice 7.5% improvement! This won't quite make up for the losses in rust-lang#44142 but I figured it's a good start. [before]: https://gist.github.com/alexcrichton/2d2b9c7a65503761925c5a0bcfeb0d1e [before]: https://gist.github.com/alexcrichton/6da51f2a6184bfb81694cc44f06deb5b
Configuration menu - View commit details
-
Copy full SHA for 3aff408 - Browse repository at this point
Copy the full SHA 3aff408View commit details -
Rollup merge of rust-lang#44589 - makotokato:thumb2, r=alexcrichton
Require +thumb-mode to generate thumb2 code for Android/armv7-a I am investigating rust's code generation into Gecko by https://bugzilla.mozilla.org/show_bug.cgi?id=1399337. armv7-linux-androideabi target uses `+v7,+thumb2,+vfp3,+d16,-neon` as target-feature. But `+thumb2` only doesn't generate thumb2 code. To generate thumb2 code, it requires `+thumb-mode`. So we should add it for armv7-linux-androideabi. r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for 47ef349 - Browse repository at this point
Copy the full SHA 47ef349View commit details -
Rollup merge of rust-lang#44590 - oli-obk:allow_unused_mut_on_vars, r…
…=eddyb Get `allow(unused_mut)` to work on `let` bindings fixes rust-lang#40491
Configuration menu - View commit details
-
Copy full SHA for 678a5c1 - Browse repository at this point
Copy the full SHA 678a5c1View commit details -
Rollup merge of rust-lang#44593 - budziq:stabilize_ord_max_min, r=ale…
…xcrichton stabilized ord_max_min (fixes rust-lang#25663)
Configuration menu - View commit details
-
Copy full SHA for 1ae6ab4 - Browse repository at this point
Copy the full SHA 1ae6ab4View commit details -
Rollup merge of rust-lang#44598 - RalfJung:installer, r=alexcrichton
update rust-installer Fixes <rust-lang#44594> r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for c1eb083 - Browse repository at this point
Copy the full SHA c1eb083View commit details -
Rollup merge of rust-lang#44603 - SimonSapin:stylo, r=alexcrichton
Add Stylo and WebRender to src/tools/cargotest This is a subset of Servo that takes relatively less time to compile and does not use unstable Rust features.
Configuration menu - View commit details
-
Copy full SHA for 101db06 - Browse repository at this point
Copy the full SHA 101db06View commit details -
Rollup merge of rust-lang#44604 - alexcrichton:update-cargo, r=Mark-S…
…imulacrum Update cargo submodule Just a routine update
Configuration menu - View commit details
-
Copy full SHA for feefb48 - Browse repository at this point
Copy the full SHA feefb48View commit details -
Rollup merge of rust-lang#44606 - alexcrichton:update-cmake, r=Mark-S…
…imulacrum rustbuild: Update `cmake` dependency Should help suppress some warnings from various repos as `cmake` in the newest version disables warnings by default.
Configuration menu - View commit details
-
Copy full SHA for ee5baff - Browse repository at this point
Copy the full SHA ee5baffView commit details -
Rollup merge of rust-lang#44609 - jonhoo:hash-alloc, r=steveklabnik
Mention that HashMap::new and HashSet::new do not allocate The docs for `HashMap::with_capacity` and `HashSet::with_capacity` already say that > If `capacity` is 0, the hash map/set will not allocate. However, the docs for `::new` do not say that the initial capacity is 0, and thus promise that a call to `::new` alone does not allocate. This PR fixes that.
Configuration menu - View commit details
-
Copy full SHA for d6c270c - Browse repository at this point
Copy the full SHA d6c270cView commit details -
Rollup merge of rust-lang#44616 - alexcrichton:rustdoc-fix-again-whee…
…, r=Mark-Simulacrum rustbuild: Fix test "test rustdoc" invocation Previously it would use the librustc output directory which would cause rustdoc to get entirely recompiled, whereas the intention is that it uses the already-compiled artifacts from building rustdoc itself, using the tool output directory
Configuration menu - View commit details
-
Copy full SHA for d59ce55 - Browse repository at this point
Copy the full SHA d59ce55View commit details -
Rollup merge of rust-lang#44622 - frewsxcv:frewsxcv-invalid-link, r=Q…
…uietMisdreavus Fix incorrect `into_inner` link in docs. Fixes rust-lang#42373.
Configuration menu - View commit details
-
Copy full SHA for 78ef3fe - Browse repository at this point
Copy the full SHA 78ef3feView commit details