Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize mem::discriminant (closes #24263) #44263

Merged
merged 1 commit into from
Sep 4, 2017

Conversation

durka
Copy link
Contributor

@durka durka commented Sep 2, 2017

No description provided.

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@dtolnay dtolnay added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 2, 2017
@dtolnay
Copy link
Member

dtolnay commented Sep 2, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Sep 2, 2017

📌 Commit d516434 has been approved by dtolnay

@est31
Copy link
Member

est31 commented Sep 2, 2017

@dtolnay if this is to be merged on beta, #44262 has to be as well.

@durka
Copy link
Contributor Author

durka commented Sep 2, 2017

If it's going to beta, the "since" field should be changed as well.

@durka
Copy link
Contributor Author

durka commented Sep 2, 2017

I don't think this depends on #44262. That splits out #[repr(i128)] from the i128_type feature gate but doesn't stabilize either one.

@est31
Copy link
Member

est31 commented Sep 2, 2017

ahh right its still unstable.

@bors
Copy link
Contributor

bors commented Sep 3, 2017

⌛ Testing commit d516434 with merge 0006d3e...

bors added a commit that referenced this pull request Sep 3, 2017
@bors
Copy link
Contributor

bors commented Sep 4, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: dtolnay
Pushing 0006d3e to master...

@bors bors merged commit d516434 into rust-lang:master Sep 4, 2017
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 13, 2017
@alexcrichton
Copy link
Member

Accepting for backport according to the last libs triage

@durka
Copy link
Contributor Author

durka commented Sep 13, 2017

@alexcrichton should I do that, or will you? including fixing up the since fields?

@alexcrichton
Copy link
Member

Ah it's ok, I'll do it at some point with other backports. Want to send a PR to master to update the fields?

@durka
Copy link
Contributor Author

durka commented Sep 13, 2017

#44552

@alexcrichton
Copy link
Member

Thanks!

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 14, 2017
update "since" for discriminant_value

It's [going](rust-lang#44263 (comment)) to be backported to beta.

r? @alexcrichton
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 14, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 15, 2017
update "since" for discriminant_value

It's [going](rust-lang#44263 (comment)) to be backported to beta.

r? @alexcrichton
@dtolnay dtolnay added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants