Issue 3563 #4376
Closed
Issue 3563 #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we would suppress error messages involving any types that contain ty_err, but that's awkward to do right now.
…unctions Necessary to allow supertrait methods to be called in default functions. As per rust-lang#3563
|
Let me think about this more carefully for a sec, but it looks correct. One caveat: this is not dynamic scoping. Dynamic scoping would mean that the body of some called function would see values set by the caller --- but this is just saying that |
|
r+ --- I think this is reasonable. |
|
Merged - 80435ad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis This patch causes
selfto be inherited from the enclosing function context when typechecking nested closures, allowing default methods to call inherited methods onself. This is effectively treatingselflike it has dynamic scope, for the purposes of typechecking. I think it should be sound to do so, since any incorrect uses ofselfwould already have been flagged by resolve.This addresses #3563.