rustbuild: Update cross-compilers for FreeBSD #43530
Conversation
When working through bugs for the LLVM 5.0 upgrade it looks like the FreeBSD cross compilers we're currently using are unable to build LLVM, failing with references to the function `std::to_string` claiming it doesn't exist. I don't actually know what this function is, but assuming that it was added in a more recent version of a C++ standard I've updated the gcc versions for the toolchains we're using. This made the error go away!
|
cc @TimNN |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I'm somewhat concerned if this is reducing how far back our support for FreeBSD goes. Otherwise though seems fine (though I also know nothing about this function). |
|
Oh sure yeah, to clarify I don't think this will impact our compatibility. We're just using a newer gcc/g++, not a newer libc or a different OS version. The one piece we need at runtime, libstdc++, is linked statically into the compiler. In that sense all our CI gcc/g++ versions are mostly picked at random, we should always be able to use the newest one in theory! Now binutils and libc, that's where things get interesting. Thankfully though we don't need updates to those. |
|
Note that |
|
Ah good point! In that sense I don't know what this does to our runtime dependency. I can try to bisect what version of gcc is actually needed but I can't help but feel like that's a bit overkill... |
|
I'm happy as-is I think. We have at least some active users of FreeBSD on nightly (I know, I broke them recently with the rustbuild changes) so I'm hopeful we'll notice quickly. Maybe we can also spin up a relatively old VM with freebsd and install stable and nightly rust after this lands. |
If you have the new build to look at, try: To the original issue, I have no idea why |
|
@cuviper oh awesome, thanks for the command! Looks like we're all good as everything's the same as it was before.
Indeed! That one even passed. No idea what's going on there... |
|
@bors: r=Mark-Simulacrum,cuviper |
|
📌 Commit 122fd18 has been approved by |
…Simulacrum,cuviper rustbuild: Update cross-compilers for FreeBSD When working through bugs for the LLVM 5.0 upgrade it looks like the FreeBSD cross compilers we're currently using are unable to build LLVM, failing with references to the function `std::to_string` claiming it doesn't exist. I don't actually know what this function is, but assuming that it was added in a more recent version of a C++ standard I've updated the gcc versions for the toolchains we're using. This made the error go away!
|
☀️ Test successful - status-appveyor, status-travis |
When working through bugs for the LLVM 5.0 upgrade it looks like the FreeBSD
cross compilers we're currently using are unable to build LLVM, failing with
references to the function
std::to_stringclaiming it doesn't exist. I don'tactually know what this function is, but assuming that it was added in a more
recent version of a C++ standard I've updated the gcc versions for the
toolchains we're using. This made the error go away!