Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Clone for .split_whitespace() #41659

Merged
merged 2 commits into from
May 10, 2017
Merged

impl Clone for .split_whitespace() #41659

merged 2 commits into from
May 10, 2017

Conversation

bluss
Copy link
Member

@bluss bluss commented Apr 30, 2017

Use custom closure structs for the predicates so that the iterator's
clone can simply be derived. This should also reduce virtual call
overhead by not using function pointers.

Fixes #41655

@bluss
std_unicode: impl Clone for .split_whitespace()
f41ecef 
Use custom closure structs for the predicates so that the iterator's
clone can simply be derived. This should also reduce virtual call
overhead by not using function pointers.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@bluss
Copy link
Member Author

bluss commented Apr 30, 2017

It's not pretty but I think it's OK to use this long kind of implementation due to its positive features.

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2017
@arielb1
Copy link
Contributor

arielb1 commented May 2, 2017

r? @aturon

@arielb1 arielb1 assigned aturon and unassigned nikomatsakis May 2, 2017
@arielb1 arielb1 requested a review from aturon May 2, 2017 09:44
@arielb1
Copy link
Contributor

arielb1 commented May 2, 2017

Thanks for the PR @bluss. @aturon (or someone else) should be reviewing your PR shortly.

@nikomatsakis
Copy link
Contributor

cc @rust-lang/libs (code seems fine to me; and I can't see any reason that this iterator shouldn't be iterable...)

@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 3, 2017
@alexcrichton
Copy link
Member

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented May 3, 2017 •
edited by BurntSushi
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@aturon
Copy link
Member

aturon commented May 5, 2017

LGTM. r=me once libs has signed off (new stable addition to std).

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2017
@aturon
Copy link
Member

aturon commented May 9, 2017

@bors: r+

@bors
Copy link
Contributor

bors commented May 9, 2017

📌 Commit 41aeb9d has been approved by aturon

@rfcbot
Copy link

rfcbot commented May 9, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label May 9, 2017
@frewsxcv frewsxcv mentioned this pull request May 10, 2017
Closed
@bors
Copy link
Contributor

bors commented May 10, 2017

⌛ Testing commit 41aeb9d with merge 58b33ad...

bors added a commit that referenced this pull request May 10, 2017
@bors
Auto merge of #41659 - bluss:clone-split-whitespace, r=aturon
58b33ad 
impl Clone for .split_whitespace()

Use custom closure structs for the predicates so that the iterator's
clone can simply be derived. This should also reduce virtual call
overhead by not using function pointers.

Fixes #41655
@bors
Copy link
Contributor

bors commented May 10, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 58b33ad to master...

@bors bors merged commit 41aeb9d into rust-lang:master May 10, 2017
@bluss bluss deleted the clone-split-whitespace branch May 10, 2017 17:18
@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aturon aturon Awaiting requested review from aturon

Assignees

@aturon aturon

Labels
final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bluss @rust-highfive @arielb1 @nikomatsakis @alexcrichton @rfcbot @aturon @bors @carols10cents @Mark-Simulacrum