Use the "official" cross compiler for NetBSD #40612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've pushed a commit with artifacts mirrored in our S3 bucket |
|
r=me as soon as this is green on travis, thanks @TimNN! |
|
I couldn't reproduce the failure locally, however it did occur again on travis (I restarted the build). This is the failure message: My intuition is that this is somehow related to sccache however I really don't know (I currently have sccache disabled locally, due to other problems). |
|
@TimNN this is likely related to |
|
@alexcrichton: Ah, thanks for the pointer, let me try that (locally). |
|
I think I fixed the problem, at least my local build seems to have gotten past the previous failure: Apparently, NetBSD has a separate So let's see what travis says. |
ranma42
reviewed
Mar 19, 2017
src/librustc_llvm/build.rs
Outdated
| "estdc++" | ||
| } else if target.contains("netbsd") && llvm_static_stdcpp.is_some() { | ||
| // NetBSD uses a separate library when reloaction is required |
There was a problem hiding this comment.
Nitpicking: s/reloaction/relocation/
|
Yay, travis is green! I removed the test commit. |
|
@bors: r+ |
|
📌 Commit e93dea1 has been approved by |
|
🔒 Merge conflict |
|
rebased |
|
@bors: r+ |
|
📌 Commit 43a51b7 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 23, 2017
Use the "official" cross compiler for NetBSD The current NetBSD cross compiler is lacking, for example `std::thread` is not available (which causes problems for LLVM 4.0). This PR uses the official netbsd build system to compiler the cross compiler. @alexcrichton: Can you please mirror `ftp://ftp.netbsd.org/pub/NetBSD/NetBSD-7.0/source/sets/{src,gnusrc,sharesrc,syssrc}.tgz`. (Optionally you may want to use NetBSD versions 7.0.2 or 7.1, in that case you'll probably want to update the binary downloads used today as well). I'll update the URL's afterwards (or feel free to use "allow edits from maintainers"). r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current NetBSD cross compiler is lacking, for example
std::threadis not available (which causes problems for LLVM 4.0). This PR uses the official netbsd build system to compiler the cross compiler.@alexcrichton: Can you please mirror
ftp://ftp.netbsd.org/pub/NetBSD/NetBSD-7.0/source/sets/{src,gnusrc,sharesrc,syssrc}.tgz. (Optionally you may want to use NetBSD versions 7.0.2 or 7.1, in that case you'll probably want to update the binary downloads used today as well).I'll update the URL's afterwards (or feel free to use "allow edits from maintainers").
r? @alexcrichton