Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inhibit enum layout optimizations under #[repr(C)] or #[repr(u8)] #40188

Merged
merged 1 commit into from
Mar 2, 2017
Merged

inhibit enum layout optimizations under #[repr(C)] or #[repr(u8)] #40188

merged 1 commit into from
Mar 2, 2017

Conversation

nikomatsakis
Copy link
Contributor

Fixes #40029

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor Author

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned arielb1 Mar 1, 2017
@nikomatsakis nikomatsakis mentioned this pull request Mar 1, 2017
Closed
@nikomatsakis
Copy link
Contributor Author

no backport needed -- presuming we land before the next beta is branched

@eddyb
Copy link
Member

eddyb commented Mar 1, 2017

@bors r+ p=1 (fixing regression)

@bors
Copy link
Contributor

bors commented Mar 1, 2017

📌 Commit 2b07d0d has been approved by eddyb

@bors
Copy link
Contributor

bors commented Mar 1, 2017

⌛ Testing commit 2b07d0d with merge b8fe36c...

@bors
Copy link
Contributor

bors commented Mar 1, 2017

💔 Test failed - status-travis

@eddyb
Copy link
Member

eddyb commented Mar 1, 2017

@bors retry

  • more S3 fallout?

@alexcrichton
Copy link
Member

Actual error is:

error: failed to execute compile

caused by: failed to spawn child

caused by: Broken pipe (os error 32)

make[3]: *** [bin/not] Error 2

I believe it's more sccache flakiness. Not sure why.

@bors
Copy link
Contributor

bors commented Mar 2, 2017

⌛ Testing commit 2b07d0d with merge 2be750b...

bors added a commit that referenced this pull request Mar 2, 2017
@bors
Auto merge of #40188 - nikomatsakis:issue-40029, r=eddyb
2be750b 
inhibit enum layout optimizations under `#[repr(C)]` or `#[repr(u8)]`

Fixes #40029
@bors
Copy link
Contributor

bors commented Mar 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 2be750b to master...

@bors bors merged commit 2b07d0d into rust-lang:master Mar 2, 2017
@nikomatsakis nikomatsakis deleted the issue-40029 branch April 14, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikomatsakis @rust-highfive @eddyb @bors @alexcrichton @arielb1